Re: [PATCH 2/2] perf tool: add container identifier entry related changes

From	Hari Bathini <hbathini@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] perf tool: add container identifier entry related changes
Date	2016-08-25 19:30 +0200
Message-ID	<sa6Dv-3XY-3@gated-at.bofh.it> (permalink)
References	<sa26R-Y5-15@gated-at.bofh.it> <sa26R-Y5-13@gated-at.bofh.it> <sa2Tf-1tU-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Thursday 25 August 2016 06:34 PM, Peter Zijlstra wrote:
> On Thu, Aug 25, 2016 at 05:28:03PM +0530, Hari Bathini wrote:
>> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
>> index d9b80ef..d35fbd3 100644
>> --- a/tools/perf/util/evsel.c
>> +++ b/tools/perf/util/evsel.c
>> @@ -929,6 +929,8 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts,
>>   	if (opts->sample_transaction)
>>   		perf_evsel__set_sample_bit(evsel, TRANSACTION);
>>   
>> +	perf_evsel__set_sample_bit(evsel, CID);
>> +
>>   	if (opts->running_time) {
>>   		evsel->attr.read_format |=
>>   			PERF_FORMAT_TOTAL_TIME_ENABLED |
> Does this mean its enabled by default? Why? By growing the default
> sample to include everything under the sun we make profiling slower for
> everyone.

True. Will put it under a flag..

- Hari

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] perf tool: add container identifier entry related  changes Hari Bathini <hbathini@linux.vnet.ibm.com> - 2016-08-25 14:40 +0200
  Re: [PATCH 2/2] perf tool: add container identifier entry related  changes Peter Zijlstra <peterz@infradead.org> - 2016-08-25 15:30 +0200
    Re: [PATCH 2/2] perf tool: add container identifier entry related  changes Hari Bathini <hbathini@linux.vnet.ibm.com> - 2016-08-25 19:30 +0200

csiph-web