Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization
Date	2016-08-25 17:50 +0200
Message-ID	<sa54K-2ST-5@gated-at.bofh.it> (permalink)
References	<s20bU-i1-9@gated-at.bofh.it> <s20lA-AN-5@gated-at.bofh.it> <sa2zT-1n5-13@gated-at.bofh.it> <sa3mh-1Ej-13@gated-at.bofh.it> <sa4Ln-2LX-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 25, 2016 at 12:17:53PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Aug 25, 2016 at 03:59:43PM +0200, Jiri Olsa escreveu:
> > On Thu, Aug 25, 2016 at 09:50:04PM +0900, Masami Hiramatsu wrote:
> > 
> > SNIP
> > 
> > > > After applying patch:
> > > > 
> > > >   $ ./perf probe -x ./test 'foo i'
> > > >   $ cat /sys/kernel/debug/tracing/uprobe_events
> > > >     p:probe_test/foo /home/ravi/test:0x0000000000000541 i=-4(%bp):s32
> > > > 
> > > >   $ ./perf record -e probe_test:foo ./test
> > > >   $ ./perf script
> > > >     test  6300 [001]  5877.879327: probe_test:foo: (400541) i=42
> > > > 
> > > > No need to skip prologue for optimized case since debug info is correct
> > > > for each instructions for -O2 -g. For more details please visit:
> > > >         https://bugzilla.redhat.com/show_bug.cgi?id=612253#c6
> > > > 
> > > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> > > 
> > > Looks good for me:)
> > > 
> > > Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> > > 
> > > Jiri, Michael, please try this. Ravi's patch can fix your problem.
> > 
> > yes, that fixes the problem for me
> 
> Ok, so I'll add a Tested-by: Jiri, ok? And push it via perf/urgent.

yep, thanks

jirka

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled  without optimization Masami Hiramatsu <mhiramat@kernel.org> - 2016-08-25 15:10 +0200
  Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled  without optimization Jiri Olsa <jolsa@redhat.com> - 2016-08-25 16:00 +0200
    Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled  without optimization Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-25 17:30 +0200
      Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled  without optimization Jiri Olsa <jolsa@redhat.com> - 2016-08-25 17:50 +0200

csiph-web