Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1470151

Re: [alsa-devel] [RFC PATCH] mfd: arizona: Add gating of external MCLKn clocks

Show all headers | View raw

On Thu, Aug 25, 2016 at 12:18:47PM +0200, Sylwester Nawrocki wrote:
> On 08/23/2016 06:28 PM, Charles Keepax wrote:
> > I think we should be able to do something requesting the 32k
> > approximately as your existing patch here does, but then
> > requesting the main MCLK from the set_pll and set_sysclk
> > handlers. Eventually I would like the internal SYSCLK and FLLs
> > represented in the clock framework, so I want to have a quick
> > think about how that would migrate over. Let me see what I can
> > come up with here.
> 
> Sounds good, I assume you mean enabling/disabling from the set_pll
> and set_syclk handlers. Do you find any issues with that? I think
> the CODEC should ensure external MCLK is enabled when setting FLL,
> otherwise it will not lock?
> Presumably arizona_set_fll() and arizona_set_sysclk() are places
> where it should be checked what the root source clock is and enable
> it if it's not yet enabled?

Yes so the MCLK needs to be available before we start the FLL, so
my thinking was we would enable the clock that corresponds
to the source for the FLL in arizona_set_fll before we start
enabling the FLL.

The direct MCLK would require a little more work but we could
probably enable the clock in this case from wm5110_sysclk_ev.

I have sent you through a copy of my prototype clock patches you
can have a look at. I am going to have a bit of a look over this
today and hopefully will be able to get back to you with more
concrete thoughts later today.

Thanks,
Charles

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH] mfd: arizona: Add gating of external MCLKn clocks Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-08-19 19:20 +0200
  Re: [RFC PATCH] mfd: arizona: Add gating of external MCLKn clocks Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-08-22 11:30 +0200
    Re: [alsa-devel] [RFC PATCH] mfd: arizona: Add gating of external  MCLKn clocks Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-08-22 19:30 +0200
      Re: [alsa-devel] [RFC PATCH] mfd: arizona: Add gating of external  MCLKn clocks Mark Brown <broonie@kernel.org> - 2016-08-22 19:50 +0200
        Re: [alsa-devel] [RFC PATCH] mfd: arizona: Add gating of external  MCLKn clocks Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-08-23 18:50 +0200
      Re: [alsa-devel] [RFC PATCH] mfd: arizona: Add gating of external  MCLKn clocks Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-08-23 18:30 +0200
        Re: [alsa-devel] [RFC PATCH] mfd: arizona: Add gating of external  MCLKn clocks Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-08-25 12:40 +0200
          Re: [alsa-devel] [RFC PATCH] mfd: arizona: Add gating of external  MCLKn clocks Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-08-25 15:40 +0200
            Re: [alsa-devel] [RFC PATCH] mfd: arizona: Add gating of external  MCLKn clocks Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-08-25 15:50 +0200

csiph-web