Re: [PATCH] serial: 8250_dw: Check the data->pclk when get apb_pclk

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] serial: 8250_dw: Check the data->pclk when get apb_pclk
Date	2016-08-25 15:20 +0200
Message-ID	<sa2JA-1qu-27@gated-at.bofh.it> (permalink)
References	<s9BT5-89D-57@gated-at.bofh.it> <sa2qd-14L-1@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Thu, 2016-08-25 at 15:55 +0300, Andy Shevchenko wrote:
> On Wed, 2016-08-24 at 16:33 +0800, Kefeng Wang wrote:
> > 
> > It should check the data->pclk, not data->clk when get apb_pclk.
> > 
> > Fixes: c8ed99d4f6a8("serial: 8250_dw: Add support for deferred
> > probing")
> > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> 
> pclk is optional on Intel platforms. With your patch we always will
> get
> EPROBE_DEFER that obviously breaks things.

Ah, sorry, it was another culprit.

Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> 
> > 
> > ---
> >  drivers/tty/serial/8250/8250_dw.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/8250/8250_dw.c
> > b/drivers/tty/serial/8250/8250_dw.c
> > index e199696..b022f5a 100644
> > --- a/drivers/tty/serial/8250/8250_dw.c
> > +++ b/drivers/tty/serial/8250/8250_dw.c
> > @@ -462,7 +462,7 @@ static int dw8250_probe(struct platform_device
> > *pdev)
> >  	}
> >  
> >  	data->pclk = devm_clk_get(&pdev->dev, "apb_pclk");
> > -	if (IS_ERR(data->clk) && PTR_ERR(data->clk) ==
> > -EPROBE_DEFER)
> > {
> > +	if (IS_ERR(data->pclk) && PTR_ERR(data->pclk) ==
> > -EPROBE_DEFER) {
> >  		err = -EPROBE_DEFER;
> >  		goto err_clk;
> >  	}
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] serial: 8250_dw: Check the data->pclk when get apb_pclk Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-08-24 10:40 +0200
  Re: [PATCH] serial: 8250_dw: Check the data->pclk when get apb_pclk Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-08-25 15:00 +0200
    Re: [PATCH] serial: 8250_dw: Check the data->pclk when get apb_pclk Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-08-25 15:20 +0200

csiph-web