Re: [PATCH] x86/mce: Use kmalloc_array() in mce_chrdev_read()

Path	csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!border2.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!bofh.it!news.nic.it!robomod
From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/mce: Use kmalloc_array() in mce_chrdev_read()
Date	Thu, 25 Aug 2016 13:40:01 +0200
Message-ID	<sa1aN-nw-3@gated-at.bofh.it> (permalink)
References	<s9YZk-7vE-51@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Transfer-Encoding	7bit
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.27
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 25 Aug 2016 11:33:44 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
X-Original-Date	Thu, 25 Aug 2016 13:33:36 +0200
X-Original-Message-ID	<865fa33f-2339-cafe-d3cc-ccf119c9a50d@redhat.com>
X-Original-References	<88a63817-f601-28ce-ed2f-ffeb28512528@users.sourceforge.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1470081

Show key headers only | View raw


On 25/08/2016 11:17, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 25 Aug 2016 11:00:05 +0200
> 
> * A multiplication for the size determination of a memory allocation
>   indicated that an array data structure should be processed.
>   Thus reuse the corresponding function "kmalloc_array".
> 
>   This issue was detected by using the Coccinelle software.
> 
> * Replace the specification of a data type by a pointer dereference
>   to make the corresponding size determination a bit safer according to
>   the Linux coding style convention.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  arch/x86/kernel/cpu/mcheck/mce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
> index 79d8ec8..0bc831d 100644
> --- a/arch/x86/kernel/cpu/mcheck/mce.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce.c
> @@ -1901,7 +1901,7 @@ static ssize_t mce_chrdev_read(struct file *filp, char __user *ubuf,
>  	unsigned prev, next;
>  	int i, err;
>  
> -	cpu_tsc = kmalloc(nr_cpu_ids * sizeof(long), GFP_KERNEL);
> +	cpu_tsc = kmalloc_array(nr_cpu_ids, sizeof(*cpu_tsc), GFP_KERNEL);
>  	if (!cpu_tsc)
>  		return -ENOMEM;
>  
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

I think you can post the patches with a larger granularity (e.g. one for
all of arch/x86/kernel).

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] x86/mce: Use kmalloc_array() in mce_chrdev_read() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-25 11:20 +0200
  Re: [PATCH] x86/mce: Use kmalloc_array() in mce_chrdev_read() Paolo Bonzini <pbonzini@redhat.com> - 2016-08-25 13:40 +0200

csiph-web