Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific

From	Rusty Russell <rusty@rustcorp.com.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific
Date	2016-08-25 13:40 +0200
Message-ID	<sa1aN-nw-1@gated-at.bofh.it> (permalink)
References	<s9O3T-87h-7@gated-at.bofh.it> <s9UM2-4BL-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Jiri Kosina <jikos@kernel.org> writes:
> On Wed, 24 Aug 2016, Josh Poimboeuf wrote:
>
>> There's no reliable way to determine which module tainted the kernel
>> with CONFIG_LIVEPATCH.  For example, /sys/module/<klp module>/taint
>> doesn't report it.  Neither does the "mod -t" command in the crash tool.
>> 
>> Make it crystal clear who the guilty party is by converting
>> CONFIG_LIVEPATCH to a module taint flag.
>> 
>> This changes the behavior a bit: now the the flag gets set when the
>> module is loaded, rather than when it's enabled.
>> 
>> Reviewed-by: Chunyu Hu <chuhu@redhat.com>
>> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
>
> I like this change.
>
> Rusty, in case you're okay with it as well, could you please either 
> provide your Ack so that I could take it through livepatching.git? 
> Alternatively, if you prefer to merge this through your tree, please feel 
> free to add

Happy to leave it to you :)

Acked-by: Rusty Russell <rusty@rustcorp.com.au>

Thanks,
Rusty.

Thread

[PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-24 23:40 +0200
  Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-24 23:50 +0200
  Re: livepatch/module: make TAINT_LIVEPATCH module-specific Jessica Yu <jeyu@redhat.com> - 2016-08-25 06:40 +0200
  Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific Jiri Kosina <jikos@kernel.org> - 2016-08-25 06:50 +0200
    Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific Rusty Russell <rusty@rustcorp.com.au> - 2016-08-25 13:40 +0200
  Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific kbuild test robot <lkp@intel.com> - 2016-08-25 08:50 +0200
  Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-25 09:00 +0200
  Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific Petr Mladek <pmladek@suse.com> - 2016-08-25 09:50 +0200
    Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-25 14:50 +0200
  Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific Miroslav Benes <mbenes@suse.cz> - 2016-08-25 16:50 +0200
    Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific Miroslav Benes <mbenes@suse.cz> - 2016-08-25 16:50 +0200
    Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-25 16:50 +0200

csiph-web