Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1470103

Re: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add regions

From Vitaly Kuznetsov <vkuznets@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add regions
Date 2016-08-25 14:20 +0200
Message-ID <sa1Nv-PS-7@gated-at.bofh.it> (permalink)
References <s9O3T-87h-3@gated-at.bofh.it> <s9O3T-87h-5@gated-at.bofh.it> <s9O3T-87h-1@gated-at.bofh.it> <s9UVH-4Gy-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Yauheni Kaliuta <yauheni.kaliuta@redhat.com> writes:

> Hi, kys!
>
>>>>>> On Wed, 24 Aug 2016 16:23:10 -0700, kys   wrote:
>
> [...]
>
>  > -static bool pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt)
>  > +static int pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt)
>  >  {
>  >  	struct list_head *cur;
>  >  	struct hv_hotadd_state *has;
>  > +	struct hv_hotadd_gap *gap;
>  >  	unsigned long residual, new_inc;
>
>  >  	if (list_empty(&dm_device.ha_region_list))
>
> One "return false;" left here.
>

This is removed in patch 4/5 of this series and false is 0 anyway)

[...]

-- 
  Vitaly

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add regions kys@exchange.microsoft.com - 2016-08-24 23:40 +0200
  Re: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add regions Yauheni Kaliuta <yauheni.kaliuta@redhat.com> - 2016-08-25 07:00 +0200
    Re: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add regions Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-08-25 14:20 +0200
    RE: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add  regions KY Srinivasan <kys@microsoft.com> - 2016-08-25 19:40 +0200

csiph-web