Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559025

Re: [patch v2] mm, memcg: do not retry precharge charges

From Johannes Weiner <hannes@cmpxchg.org>
Newsgroups linux.kernel
Subject Re: [patch v2] mm, memcg: do not retry precharge charges
Date 2017-01-14 17:30 +0100
Message-ID <sZznk-88f-21@gated-at.bofh.it> (permalink)
References <sYFl8-7QL-17@gated-at.bofh.it> <sYWlZ-1cO-27@gated-at.bofh.it> <sZ5IC-75W-9@gated-at.bofh.it> <sZ77I-83Q-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 13, 2017 at 02:09:53AM -0800, David Rientjes wrote:
> When memory.move_charge_at_immigrate is enabled and precharges are
> depleted during move, mem_cgroup_move_charge_pte_range() will attempt to
> increase the size of the precharge.
> 
> Prevent precharges from ever looping by setting __GFP_NORETRY.  This was
> probably the intention of the GFP_KERNEL & ~__GFP_NORETRY, which is
> pointless as written.

The OOM killer livelock was the motivation for this patch. With that
ruled out, what's the point of this patch? Try a bit less hard to move
charges during task migration?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch] mm, memcg: do not retry precharge charges David Rientjes <rientjes@google.com> - 2017-01-12 05:40 +0100
  Re: [patch] mm, memcg: do not retry precharge charges Michal Hocko <mhocko@kernel.org> - 2017-01-12 11:10 +0100
  Re: [patch] mm, memcg: do not retry precharge charges Michal Hocko <mhocko@kernel.org> - 2017-01-12 11:20 +0100
  [patch v2] mm, memcg: do not retry precharge charges David Rientjes <rientjes@google.com> - 2017-01-12 23:50 +0100
    Re: [patch v2] mm, memcg: do not retry precharge charges Michal Hocko <mhocko@kernel.org> - 2017-01-13 09:50 +0100
      Re: [patch v2] mm, memcg: do not retry precharge charges David Rientjes <rientjes@google.com> - 2017-01-13 11:20 +0100
        Re: [patch v2] mm, memcg: do not retry precharge charges Johannes Weiner <hannes@cmpxchg.org> - 2017-01-14 17:30 +0100
          Re: [patch v2] mm, memcg: do not retry precharge charges David Rientjes <rientjes@google.com> - 2017-01-15 06:50 +0100
            Re: [patch v2] mm, memcg: do not retry precharge charges Johannes Weiner <hannes@cmpxchg.org> - 2017-01-15 16:20 +0100
            Re: [patch v2] mm, memcg: do not retry precharge charges Michal Hocko <mhocko@kernel.org> - 2017-01-16 08:40 +0100

csiph-web