Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559001

Re: [PATCH] iio: magnetometer: ak8974: remove redundant zero timeout check

Show all headers | View raw

On 11/01/17 23:11, Linus Walleij wrote:
> On Wed, Jan 11, 2017 at 6:49 PM, Colin King <colin.king@canonical.com> wrote:
> 
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> At the end of the delay loop timeout will always be zero
>> and hence the check for !timeout will always be true. Remove
>> the redundant check and the redundant return 0 at the end of
>> the function.
>>
>> Fixes CoverityScan CID#1357168 ("Logically dead code")
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Clever Coverity scan.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan
> Yours,
> Linus Walleij
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iio: magnetometer: ak8974: remove redundant zero timeout check Colin King <colin.king@canonical.com> - 2017-01-11 19:00 +0100
  Re: [PATCH] iio: magnetometer: ak8974: remove redundant zero timeout check Linus Walleij <linus.walleij@linaro.org> - 2017-01-12 00:20 +0100
    Re: [PATCH] iio: magnetometer: ak8974: remove redundant zero timeout  check Jonathan Cameron <jic23@kernel.org> - 2017-01-14 14:20 +0100

csiph-web