Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1558943
| From | John Crispin <john@phrozen.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 5/6] arm: dts: mt2701: Add ethernet device node. |
| Date | 2017-01-14 11:40 +0100 |
| Message-ID | <sZtUC-4P6-37@gated-at.bofh.it> (permalink) |
| References | <sZ5Sh-79g-9@gated-at.bofh.it> <sZ5Si-79g-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Erin,
small comment inline
On 13/01/2017 09:42, Erin Lo wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> Add ethernet device node for MT2701.
>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> Signed-off-by: Erin Lo <erin.lo@mediatek.com>
> ---
> arch/arm/boot/dts/mt2701-evb.dts | 40 ++++++++++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/mt2701.dtsi | 22 ++++++++++++++++++++++
> 2 files changed, 62 insertions(+)
>
> diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts
> index a483798..40abd3b 100644
> --- a/arch/arm/boot/dts/mt2701-evb.dts
> +++ b/arch/arm/boot/dts/mt2701-evb.dts
> @@ -28,7 +28,47 @@
> status = "okay";
> };
>
> +ð {
> + mac-address = [00 00 00 00 00 00];
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&gmac1_pins>;
> + gmac1: mac@1 {
> + compatible = "mediatek,eth-mac";
> + reg = <1>;
> + phy-handle = <&phy5>;
> + };
> +
> + mdio-bus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + phy5: ethernet-phy@5 {
> + reg = <5>;
> + phy-mode = "rgmii-rxid";
> + };
> + };
> +};
> +
> &pio {
> + gmac1_pins: eth@0 {
> + pins_eth {
> + pinmux = <MT2701_PIN_275_MDC__FUNC_MDC>,
> + <MT2701_PIN_276_MDIO__FUNC_MDIO>,
> + <MT2701_PIN_262_G2_TXEN__FUNC_G2_TXEN>,
> + <MT2701_PIN_263_G2_TXD3__FUNC_G2_TXD3>,
> + <MT2701_PIN_264_G2_TXD2__FUNC_G2_TXD2>,
> + <MT2701_PIN_265_G2_TXD1__FUNC_G2_TXD1>,
> + <MT2701_PIN_266_G2_TXD0__FUNC_G2_TXD0>,
> + <MT2701_PIN_267_G2_TXC__FUNC_G2_TXC>,
> + <MT2701_PIN_268_G2_RXC__FUNC_G2_RXC>,
> + <MT2701_PIN_269_G2_RXD0__FUNC_G2_RXD0>,
> + <MT2701_PIN_270_G2_RXD1__FUNC_G2_RXD1>,
> + <MT2701_PIN_271_G2_RXD2__FUNC_G2_RXD2>,
> + <MT2701_PIN_272_G2_RXD3__FUNC_G2_RXD3>,
> + <MT2701_PIN_274_G2_RXDV__FUNC_G2_RXDV>;
> + };
> + };
> +
> spi_pins_a: spi0@0 {
> pins_spi {
> pinmux = <MT2701_PIN_53_SPI0_CSN__FUNC_SPI0_CS>,
> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
> index 4f52019..3847f70 100644
> --- a/arch/arm/boot/dts/mt2701.dtsi
> +++ b/arch/arm/boot/dts/mt2701.dtsi
> @@ -381,6 +381,28 @@
> #clock-cells = <1>;
> };
>
> + eth: ethernet@1b100000 {
> + compatible = "mediatek,mt7623-eth";
> + reg = <0 0x1b100000 0 0x20000>;
> + interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 199 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 198 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&topckgen CLK_TOP_ETHIF_SEL>,
> + <&apmixedsys CLK_APMIXED_TRGPLL>,
> + <ðsys CLK_ETHSYS_ESW>,
> + <ðsys CLK_ETHSYS_GP2>,
> + <ðsys CLK_ETHSYS_GP1>;
> + clock-names = "ethif", "trgpll", "esw", "gp2", "gp1";
> + power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
> + resets = <&watchdog MT2701_TOPRGU_ETHDMA_RST>;
are you sure this is correct ? on mt7623 we point the reset at ethsys
and not the watchdog.
John
> + reset-names = "eth";
> + mediatek,ethsys = <ðsys>;
> + mediatek,pctl = <&syscfg_pctl_a>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> bdpsys: syscon@1c000000 {
> compatible = "mediatek,mt2701-bdpsys", "syscon";
> reg = <0 0x1c000000 0 0x1000>;
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/6] Add some DT nodes for Mediatek MT2701 Erin Lo <erin.lo@mediatek.com> - 2017-01-13 10:00 +0100
[PATCH v2 6/6] arm: dts: mt2701: Add thermal device node. Erin Lo <erin.lo@mediatek.com> - 2017-01-13 10:00 +0100
Re: [PATCH v2 6/6] arm: dts: mt2701: Add thermal device node. Matthias Brugger <matthias.bgg@gmail.com> - 2017-01-13 16:30 +0100
Re: [PATCH v2 6/6] arm: dts: mt2701: Add thermal device node. Dawei Chien <dawei.chien@mediatek.com> - 2017-01-16 04:50 +0100
Re: [PATCH v2 6/6] arm: dts: mt2701: Add thermal device node. Dawei Chien <dawei.chien@mediatek.com> - 2017-01-16 04:50 +0100
[PATCH v2 1/6] arm: dts: mt2701: Add spi device node Erin Lo <erin.lo@mediatek.com> - 2017-01-13 10:00 +0100
Re: [PATCH v2 1/6] arm: dts: mt2701: Add spi device node Matthias Brugger <matthias.bgg@gmail.com> - 2017-01-13 16:30 +0100
[PATCH v2 4/6] arm: dts: mt2701: Add auxadc device node. Erin Lo <erin.lo@mediatek.com> - 2017-01-13 10:00 +0100
Re: [PATCH v2 4/6] arm: dts: mt2701: Add auxadc device node. Matthias Brugger <matthias.bgg@gmail.com> - 2017-01-13 16:30 +0100
[PATCH v2 3/6] arm: dts: mt2701: Add nand device node Erin Lo <erin.lo@mediatek.com> - 2017-01-13 10:00 +0100
Re: [PATCH v2 3/6] arm: dts: mt2701: Add nand device node Matthias Brugger <matthias.bgg@gmail.com> - 2017-01-13 16:30 +0100
[PATCH v2 5/6] arm: dts: mt2701: Add ethernet device node. Erin Lo <erin.lo@mediatek.com> - 2017-01-13 10:00 +0100
Re: [PATCH v2 5/6] arm: dts: mt2701: Add ethernet device node. John Crispin <john@phrozen.org> - 2017-01-14 11:40 +0100
Re: [PATCH v2 5/6] arm: dts: mt2701: Add ethernet device node. Sean Wang <sean.wang@mediatek.com> - 2017-01-14 17:20 +0100
[PATCH v2 2/6] arm: dts: mt2701: Add iommu/smi device node Erin Lo <erin.lo@mediatek.com> - 2017-01-13 10:00 +0100
Re: [PATCH v2 2/6] arm: dts: mt2701: Add iommu/smi device node Matthias Brugger <matthias.bgg@gmail.com> - 2017-01-13 16:10 +0100
Re: [PATCH v2 2/6] arm: dts: mt2701: Add iommu/smi device node Honghui Zhang <honghui.zhang@mediatek.com> - 2017-01-16 04:00 +0100
csiph-web