Re: [PATCH] cxgb4: Remove redundant memset before memcpy

From	Shyam Saini <mayhs11saini@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cxgb4: Remove redundant memset before memcpy
Date	2017-01-14 02:00 +0100
Message-ID	<sZkRk-7LO-9@gated-at.bofh.it> (permalink)
References	<sZ6Or-7I1-21@gated-at.bofh.it> <sZcqJ-2FK-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 13, 2017 at 04:57:14PM +0100, Tobias Klauser wrote:
> On 2017-01-13 at 10:52:49 +0100, Shyam Saini <mayhs11saini@gmail.com> wrote:
> > The region set by the call to memset, immediately overwritten by the
> > subsequent call to memcpy and thus makes the  memset redundant
> > 
> > Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
> > ---
> >  drivers/net/ethernet/chelsio/cxgb4/sched.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c b/drivers/net/ethernet/chelsio/cxgb4/sched.c
> > index cbd68a8..5725693 100644
> > --- a/drivers/net/ethernet/chelsio/cxgb4/sched.c
> > +++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c
> > @@ -398,7 +398,6 @@ static struct sched_class *t4_sched_class_lookup(struct port_info *pi,
> >  		struct ch_sched_params tp;
> >  
> >  		memset(&info, 0, sizeof(info));
> 
> This memset is also redundant because info is memcpy()'ed to before
> being used in the loop (and it isn't used outside of the loop).
Thanks a lot for pointing out that.

I'll remove that too and resend it.

Regards,
Shyam

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cxgb4: Remove redundant memset before memcpy Shyam Saini <mayhs11saini@gmail.com> - 2017-01-13 11:00 +0100
  Re: [PATCH] cxgb4: Remove redundant memset before memcpy Tobias Klauser <tklauser@distanz.ch> - 2017-01-13 17:00 +0100
    Re: [PATCH] cxgb4: Remove redundant memset before memcpy Shyam Saini <mayhs11saini@gmail.com> - 2017-01-14 02:00 +0100

csiph-web