Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1558685
| From | Eric Dumazet <eric.dumazet@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH][V2] flow dissector: check if arp_eth is null rather than arp |
| Date | 2017-01-13 20:10 +0100 |
| Message-ID | <sZfoB-4EY-17@gated-at.bofh.it> (permalink) |
| References | <sZf5f-4iZ-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 2017-01-13 at 18:48 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> arp is being checked instead of arp_eth to see if the call to
> __skb_header_pointer failed. Fix this by checking arp_eth is
> null instead of arp. Also fix to use length hlen rather than
> hlen - sizeof(_arp); thanks to Eric Dumazet for spotting
> this latter issue.
>
> CoverityScan CID#1396428 ("Logically dead code") on 2nd
> arp comparison (which should be arp_eth instead).
>
> Fixes: commit 55733350e5e8b70c5 ("flow disector: ARP support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Acked-by: Eric Dumazet <edumazet@google.com>
Thanks !
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH][V2] flow dissector: check if arp_eth is null rather than arp Colin King <colin.king@canonical.com> - 2017-01-13 19:50 +0100 Re: [PATCH][V2] flow dissector: check if arp_eth is null rather than arp Eric Dumazet <eric.dumazet@gmail.com> - 2017-01-13 20:10 +0100 Re: [PATCH][V2] flow dissector: check if arp_eth is null rather than arp David Miller <davem@davemloft.net> - 2017-01-16 19:50 +0100
csiph-web