Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1558659

Re: [PATCH v3] ARM: dts: Add LEGO MINDSTORMS EV3 dts

Show all headers | View raw

On 01/13/2017 06:04 AM, Sekhar Nori wrote:
> On Friday 13 January 2017 02:02 AM, David Lechner wrote:
>> This adds a device tree definition file for LEGO MINDSTORMS EV3.
>>
...
>
> There are couple of checkpatch errors that show up. The compatible
> "lego,ev3" needs to be documented in
> Documentation/devicetree/bindings/arm/davinci.txt
>
> "at24,24c128" is undocumented. Is that an atmel chip on the EV3? If the
> manufacturer name is not clear,
> Documentation/devicetree/bindings/eeprom/eeprom.txt advises using just
> "24c128"

The mfg is microchip, so I guess I will just go with "24c128"

>
> Finally, lego needs to be added to
> Documentation/devicetree/bindings/vendor-prefixes.txt
>
> Can you please submit the documentation portions as separate patches in
> a series along with this patch.

Yes.

>
> Thanks,
> Sekhar
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] ARM: dts: Add LEGO MINDSTORMS EV3 dts David Lechner <david@lechnology.com> - 2017-01-12 21:40 +0100
  Re: [PATCH v3] ARM: dts: Add LEGO MINDSTORMS EV3 dts Sekhar Nori <nsekhar@ti.com> - 2017-01-13 13:10 +0100
    Re: [PATCH v3] ARM: dts: Add LEGO MINDSTORMS EV3 dts David Lechner <david@lechnology.com> - 2017-01-13 19:20 +0100
      Re: [PATCH v3] ARM: dts: Add LEGO MINDSTORMS EV3 dts David Lechner <david@lechnology.com> - 2017-01-13 19:30 +0100
  Re: [PATCH v3] ARM: dts: Add LEGO MINDSTORMS EV3 dts kbuild test robot <lkp@intel.com> - 2017-01-15 01:20 +0100

csiph-web