Re: [PATCH 01/10] block: move existing elevator ops to union

From	Jens Axboe <axboe@kernel.dk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/10] block: move existing elevator ops to union
Date	2017-01-13 16:10 +0100
Message-ID	<sZbEl-2pl-1@gated-at.bofh.it> (permalink)
References	<sYyWl-3GV-7@gated-at.bofh.it> <sYyWl-3GV-13@gated-at.bofh.it> <sZ5yV-72H-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 13 2017, Christoph Hellwig wrote:
> On Wed, Jan 11, 2017 at 02:39:54PM -0700, Jens Axboe wrote:
> > Prep patch for adding MQ ops as well, since doing anon unions with
> > named initializers doesn't work on older compilers.
> 
> My gut feeling tells me MQ schedulers shouldn't share elevator_type.
> I'll play around a bit with the code later to see if my gut was right.

It's crazy to re-invent a new framework just for MQ schedulers, imho. So
you're going to have to come up with something better than a gut
feeling.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 01/10] block: move existing elevator ops to union Jens Axboe <axboe@fb.com> - 2017-01-11 22:50 +0100
  Re: [PATCH 01/10] block: move existing elevator ops to union Johannes Thumshirn <jthumshirn@suse.de> - 2017-01-12 11:20 +0100
  Re: [PATCH 01/10] block: move existing elevator ops to union Christoph Hellwig <hch@infradead.org> - 2017-01-13 09:40 +0100
    Re: [PATCH 01/10] block: move existing elevator ops to union Jens Axboe <axboe@kernel.dk> - 2017-01-13 16:10 +0100

csiph-web