Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1558423
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next v2 08/10] net: dsa: Add support for platform data |
| Date | 2017-01-13 15:10 +0100 |
| Message-ID | <sZaIh-1Qx-7@gated-at.bofh.it> (permalink) |
| References | <sYEyJ-7iM-5@gated-at.bofh.it> <sYEyJ-7iM-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> index cd91070b5467..d326fc4afad7 100644
> --- a/net/dsa/dsa2.c
> +++ b/net/dsa/dsa2.c
> @@ -81,17 +81,23 @@ static void dsa_dst_del_ds(struct dsa_switch_tree *dst,
>
> static bool dsa_port_is_valid(struct dsa_port *port)
> {
> - return !!port->dn;
> + return !!(port->dn || port->name);
> }
Does this clash with Viviens recent change to make names optional and
have the kernel assign it?
I suppose you could use an name of "eth%d"? Is it worth adding a
comment to the platform data structure?
Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next v2 08/10] net: dsa: Add support for platform data Florian Fainelli <f.fainelli@gmail.com> - 2017-01-12 04:50 +0100
Re: [PATCH net-next v2 08/10] net: dsa: Add support for platform data Andrew Lunn <andrew@lunn.ch> - 2017-01-13 15:10 +0100
Re: [PATCH net-next v2 08/10] net: dsa: Add support for platform data Florian Fainelli <f.fainelli@gmail.com> - 2017-01-13 23:40 +0100
Re: [PATCH net-next v2 08/10] net: dsa: Add support for platform data Florian Fainelli <f.fainelli@gmail.com> - 2017-01-14 20:20 +0100
Re: [PATCH net-next v2 08/10] net: dsa: Add support for platform data Andrew Lunn <andrew@lunn.ch> - 2017-01-13 15:20 +0100
Re: [PATCH net-next v2 08/10] net: dsa: Add support for platform data Florian Fainelli <f.fainelli@gmail.com> - 2017-01-13 23:40 +0100
csiph-web