Re: [PATCH linux v2 0/6] drivers: hwmon: Add On-Chip Controller driver

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH linux v2 0/6] drivers: hwmon: Add On-Chip Controller driver
Date	Sun, 15 Jan 2017 19:40:01 +0100
Message-ID	<sZXSF-5R9-7@gated-at.bofh.it> (permalink)
References	<sYvF8-1NE-11@gated-at.bofh.it>
X-Original-To	eajames.ibm@gmail.com
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To:Subject; bh=mRBWtKK/1OV76nZP0ILq0amb6k6ipJKf09LVCandm9g=; b=XTPylWY7v18D1cuE41S0RiX1XM KIy46kSfybbgJE9MhcxlnSPWD38mjSPsbjDg3U0MRUNyDqA1/aQax14KN/lKMtEjzavdGt0luqEs9 1ezmceYp9iZsShDyDu/3VH1Ff+e1dcl8FEaEx7zo9zL0wKP7mfMqWm2R1w3vBoT5zlUw0JLKD1PUu eeiAHsb7hHu0KL30RdjV5nkeBrhsp76hXWudS3cJcZ8vDbdLpn50GPICKCOQBUfD8UScl7d/77zgF h+AuJ+gHYoazEQihXu6ElFkcR45VMf0l+LkgIB9xxHo3N/pYHoCuiaJsAmx1FQsp2b7L+Asy4g0tM EnO1Ob5Q==;
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
X-Authenticated_Sender	linux@roeck-us.net
X-Outgoing-Spam-Status	No, score=-1.0
X-Antiabuse	This header was added to track abuse, please include it with any abuse report
X-Antiabuse	Primary Hostname - bh-25.webhostbox.net
X-Antiabuse	Original Domain - vger.kernel.org
X-Antiabuse	Originator/Caller UID/GID - [47 12] / [47 12]
X-Antiabuse	Sender Address Domain - roeck-us.net
X-Get-Message-Sender-Via	bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net
X-Authenticated-Sender	bh-25.webhostbox.net: linux@roeck-us.net
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	67
Organization	linux.* mail to news gateway
X-Original-Cc	devicetree@vger.kernel.org, jdelvare@suse.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, wsa@the-dreams.de, andrew@aj.id.au, joel@jms.id.au, benh@kernel.crashing.org, "Edward A. James" <eajames@us.ibm.com>
X-Original-Date	Sun, 15 Jan 2017 10:35:10 -0800
X-Original-Message-ID	<ee855470-25fd-b29b-b9fc-5e4dae110cd3@roeck-us.net>
X-Original-References	<1484158237-10014-1-git-send-email-eajames.ibm@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1559322

Show key headers only | View raw

On 01/11/2017 10:10 AM, eajames.ibm@gmail.com wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
>
> This patchset adds a hwmon driver to support the OCC (On-Chip Controller)
> on the IBM POWER8 and POWER9 processors, from a BMC (Baseboard Management
> Controller). The OCC is an embedded processor that provides real time
> power and thermal monitoring.
>
> The driver provides an interface on a BMC to poll OCC sensor data, set
> user power caps, and perform some basic OCC error handling. It interfaces
> with userspace through hwmon.
>
> The driver is currently functional only for the OCC on POWER8 chips.
> Communicating with the POWER9 OCC requries FSI support.
>

Overall looks pretty good. There is the 0day hiccup (was that solved ?) and
a few comments I made separately. It might make sense to add someone from IBM
as maintainer.

Thanks,
Guenter

> Edward A. James (6):
>   hwmon: Add core On-Chip Controller support for POWER CPUs
>   hwmon: occ: Add sysfs interface
>   hwmon: occ: Add I2C transport implementation for SCOM operations
>   hwmon: occ: Add callbacks for parsing P8 OCC datastructures
>   hwmon: occ: Add hwmon implementation for the P8 OCC
>   hwmon: occ: Add callbacks for parsing P9 OCC datastructures
>
>  Documentation/devicetree/bindings/hwmon/occ.txt |  13 +
>  Documentation/hwmon/occ                         | 114 +++++
>  drivers/hwmon/Kconfig                           |   2 +
>  drivers/hwmon/Makefile                          |   1 +
>  drivers/hwmon/occ/Kconfig                       |  29 ++
>  drivers/hwmon/occ/Makefile                      |   2 +
>  drivers/hwmon/occ/occ.c                         | 533 ++++++++++++++++++++++++
>  drivers/hwmon/occ/occ.h                         |  83 ++++
>  drivers/hwmon/occ/occ_p8.c                      | 254 +++++++++++
>  drivers/hwmon/occ/occ_p8.h                      |  31 ++
>  drivers/hwmon/occ/occ_p9.c                      | 314 ++++++++++++++
>  drivers/hwmon/occ/occ_p9.h                      |  31 ++
>  drivers/hwmon/occ/occ_scom_i2c.c                |  73 ++++
>  drivers/hwmon/occ/occ_scom_i2c.h                |  26 ++
>  drivers/hwmon/occ/occ_sysfs.c                   | 274 ++++++++++++
>  drivers/hwmon/occ/occ_sysfs.h                   |  44 ++
>  drivers/hwmon/occ/p8_occ_i2c.c                  | 123 ++++++
>  drivers/hwmon/occ/scom.h                        |  47 +++
>  18 files changed, 1994 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/occ.txt
>  create mode 100644 Documentation/hwmon/occ
>  create mode 100644 drivers/hwmon/occ/Kconfig
>  create mode 100644 drivers/hwmon/occ/Makefile
>  create mode 100644 drivers/hwmon/occ/occ.c
>  create mode 100644 drivers/hwmon/occ/occ.h
>  create mode 100644 drivers/hwmon/occ/occ_p8.c
>  create mode 100644 drivers/hwmon/occ/occ_p8.h
>  create mode 100644 drivers/hwmon/occ/occ_p9.c
>  create mode 100644 drivers/hwmon/occ/occ_p9.h
>  create mode 100644 drivers/hwmon/occ/occ_scom_i2c.c
>  create mode 100644 drivers/hwmon/occ/occ_scom_i2c.h
>  create mode 100644 drivers/hwmon/occ/occ_sysfs.c
>  create mode 100644 drivers/hwmon/occ/occ_sysfs.h
>  create mode 100644 drivers/hwmon/occ/p8_occ_i2c.c
>  create mode 100644 drivers/hwmon/occ/scom.h
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH linux v2 0/6] drivers: hwmon: Add On-Chip Controller driver eajames.ibm@gmail.com - 2017-01-11 19:20 +0100
  [PATCH linux v2 3/6] hwmon: occ: Add I2C transport implementation for SCOM operations eajames.ibm@gmail.com - 2017-01-11 19:20 +0100
  [PATCH linux v2 1/6] hwmon: Add core On-Chip Controller support for POWER CPUs eajames.ibm@gmail.com - 2017-01-11 19:20 +0100
  [PATCH linux v2 4/6] hwmon: occ: Add callbacks for parsing P8 OCC datastructures eajames.ibm@gmail.com - 2017-01-11 19:20 +0100
  [PATCH linux v2 5/6] hwmon: occ: Add hwmon implementation for the P8 OCC eajames.ibm@gmail.com - 2017-01-11 19:20 +0100
    Re: [PATCH linux v2 5/6] hwmon: occ: Add hwmon implementation for the  P8 OCC Guenter Roeck <linux@roeck-us.net> - 2017-01-15 19:20 +0100
    Re: [PATCH linux v2 5/6] hwmon: occ: Add hwmon implementation for the  P8 OCC Guenter Roeck <linux@roeck-us.net> - 2017-01-15 19:40 +0100
  [PATCH linux v2 6/6] hwmon: occ: Add callbacks for parsing P9 OCC datastructures eajames.ibm@gmail.com - 2017-01-11 19:20 +0100
  Re: [PATCH linux v2 0/6] drivers: hwmon: Add On-Chip Controller  driver Wolfram Sang <wsa@the-dreams.de> - 2017-01-12 11:00 +0100
  Re: [PATCH linux v2 0/6] drivers: hwmon: Add On-Chip Controller  driver Guenter Roeck <linux@roeck-us.net> - 2017-01-15 19:40 +0100

csiph-web