Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1559220

[PATCH 1/1] ASoC: fsl_asrc: use dma_transfer_direction enum when calling dmaengine_prep_dma_cyclic

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Newsgroups linux.kernel
Subject [PATCH 1/1] ASoC: fsl_asrc: use dma_transfer_direction enum when calling dmaengine_prep_dma_cyclic
Date Sun, 15 Jan 2017 13:50:01 +0100
Message-ID <sZSpX-2zL-9@gated-at.bofh.it> (permalink)
X-Mailer git-send-email 2.11.0
X-Av-Checked ClamAV using ClamSMTP at svoboda.polytechnique.org (Sun Jan 15 13:43:39 2017 +0100 (CET))
X-Spam-Flag No, tests=bogofilter, spamicity=0.000046, queueID=527A3560791
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 29
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org, Nicolas Iooss <nicolas.iooss_linux@m4x.org>
X-Original-Date Sun, 15 Jan 2017 13:43:31 +0100
X-Original-Message-ID <20170115124331.3546-1-nicolas.iooss_linux@m4x.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1559220

Show key headers only | View raw


When fsl_asrc_dma_prepare_and_submit() calls
dmaengine_prep_dma_cyclic(), it uses either DMA_TO_DEVICE or
DMA_FROM_DEVICE. These values are both items of dma_data_direction enum,
not of dma_data_direction enum, which is the type expected by
dmaengine_prep_dma_cyclic().

Replace DMA_TO_DEVICE with DMA_MEM_TO_DEV and DMA_FROM_DEVICE with
DMA_DEV_TO_MEM to fix this type mismatch issue.

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
 sound/soc/fsl/fsl_asrc_dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c
index dc30d780f874..282d841840b1 100644
--- a/sound/soc/fsl/fsl_asrc_dma.c
+++ b/sound/soc/fsl/fsl_asrc_dma.c
@@ -76,7 +76,7 @@ static int fsl_asrc_dma_prepare_and_submit(struct snd_pcm_substream *substream)
 			pair->dma_chan[!dir], runtime->dma_addr,
 			snd_pcm_lib_buffer_bytes(substream),
 			snd_pcm_lib_period_bytes(substream),
-			dir == OUT ? DMA_TO_DEVICE : DMA_FROM_DEVICE, flags);
+			dir == OUT ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM, flags);
 	if (!pair->desc[!dir]) {
 		dev_err(dev, "failed to prepare slave DMA for Front-End\n");
 		return -ENOMEM;
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/1] ASoC: fsl_asrc: use dma_transfer_direction enum when calling dmaengine_prep_dma_cyclic Nicolas Iooss <nicolas.iooss_linux@m4x.org> - 2017-01-15 13:50 +0100
  Re: [alsa-devel] [PATCH 1/1] ASoC: fsl_asrc: use dma_transfer_direction  enum when calling dmaengine_prep_dma_cyclic Fabio Estevam <festevam@gmail.com> - 2017-01-15 14:30 +0100
  Re: [PATCH 1/1] ASoC: fsl_asrc: use dma_transfer_direction enum when  calling dmaengine_prep_dma_cyclic Nicolin Chen <nicoleotsuka@gmail.com> - 2017-01-15 20:20 +0100

csiph-web