Re: [PATCH] drivers: staging: rtl8188eu: include: Removed unnecssary defined macros

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers: staging: rtl8188eu: include: Removed unnecssary defined macros
Date	2017-01-15 12:00 +0100
Message-ID	<sZQHw-1wB-5@gated-at.bofh.it> (permalink)
References	<sZNzY-8dA-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jan 15, 2017 at 01:09:23PM +0530, Kartikey Singh wrote:
> Removed macros not in use.
> 
> Signed-off-by: Kartikey Singh <dr.kartikeynrc@gmail.com>
> ---
>  drivers/staging/rtl8188eu/include/wifi.h | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/include/wifi.h b/drivers/staging/rtl8188eu/include/wifi.h
> index 9e08e68..9c9c334 100644
> --- a/drivers/staging/rtl8188eu/include/wifi.h
> +++ b/drivers/staging/rtl8188eu/include/wifi.h
> @@ -480,15 +480,6 @@ static inline int IsFrameTypeCtrl(unsigned char *pframe)
>  				Below is the definition for 802.11n
>  ------------------------------------------------------------------------------*/
>  
> -#define SetOrderBit(pbuf)	\
> -	do	{	\
> -		*(unsigned short *)(pbuf) |= cpu_to_le16(_ORDER_); \
> -	} while (0)
> -
> -#define GetOrderBit(pbuf)			\
> -	(((*(unsigned short *)(pbuf)) & le16_to_cpu(_ORDER_)) != 0)
> -
> -

That's good, but:

>  /**
>   * struct rtw_ieee80211_bar - HT Block Ack Request
>   *
> @@ -758,6 +749,8 @@ enum ht_cap_ampdu_factor {
>  #define	P2P_STATUS_FAIL_USER_REJECT			0x0B
>  
>  /*	Value of Invitation Flags Attribute */
> +
> +/*
>  #define	P2P_INVITATION_FLAGS_PERSISTENT			BIT(0)
>  
>  #define	DMP_P2P_DEVCAP_SUPPORT	(P2P_DEVCAP_SERVICE_DISCOVERY | \
> @@ -766,6 +759,7 @@ enum ht_cap_ampdu_factor {
>  				P2P_DEVCAP_INVITATION_PROC)
>  
>  #define	DMP_P2P_GRPCAP_SUPPORT	(P2P_GRPCAP_INTRABSS)
> +*/

Why did you comment these out and not just remove them?

No need keeping around useless stuff, right?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drivers: staging: rtl8188eu: include: Removed unnecssary  defined macros Kartikey Singh <dr.kartikeynrc@gmail.com> - 2017-01-15 08:40 +0100
  Re: [PATCH] drivers: staging: rtl8188eu: include: Removed unnecssary  defined macros Greg KH <gregkh@linuxfoundation.org> - 2017-01-15 12:00 +0100

csiph-web