Re: [PATCH 02/12] PM / OPP: Add 'struct kref' to OPP table

From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/12] PM / OPP: Add 'struct kref' to OPP table
Date	2017-01-13 10:00 +0100
Message-ID	<sZ5Sh-79g-1@gated-at.bofh.it> (permalink)
References	<sLHNL-7ku-5@gated-at.bofh.it> <sLHXs-7qQ-25@gated-at.bofh.it> <sXRHH-231-5@gated-at.bofh.it> <sXWem-53H-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/10, Viresh Kumar wrote:
> On 09-01-17, 15:36, Stephen Boyd wrote:
> 
> > It would be better to have _find_opp_table()
> > return the pointer with the reference already taken so that we
> > don't have to update callers with reference grabbing calls.
> > Typically if a function returns a reference counted pointer the
> > reference counting has already been done.
> 
> Absolutely, but that happens with later patches in the series. I couldn't have
> done it now, as something or the other would have broken.
> 

Ok, if things get better later in the series then you can have my

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 02/12] PM / OPP: Add 'struct kref' to OPP table Stephen Boyd <sboyd@codeaurora.org> - 2017-01-10 00:40 +0100
  Re: [PATCH 02/12] PM / OPP: Add 'struct kref' to OPP table Viresh Kumar <viresh.kumar@linaro.org> - 2017-01-10 05:30 +0100
    Re: [PATCH 02/12] PM / OPP: Add 'struct kref' to OPP table Stephen Boyd <sboyd@codeaurora.org> - 2017-01-13 10:00 +0100

csiph-web