Re: [PATCH v5 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor
Date	2017-01-13 06:40 +0100
Message-ID	<sZ2KJ-5mj-19@gated-at.bofh.it> (permalink)
References	<sXXk6-5LU-43@gated-at.bofh.it> <sXY6t-6i7-5@gated-at.bofh.it> <sXY6t-6i7-3@gated-at.bofh.it> <sZ2KJ-5mj-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 13, 2017 at 04:28:11AM +0000, Appana Durga Kedareswara Rao wrote:
> Hi Vinod,
> 
> 	Thanks for the review...
> > 
> > On Sat, Jan 07, 2017 at 12:15:28PM +0530, Kedareswara rao Appana wrote:
> > > Add channel idle state to ensure that dma descriptor is not
> > > submitted when VDMA engine is in progress.
> > 
> > any reason why you want to make your own varible and not use the HW to
> > query
> > as done earlier. It is not clear to me why that is removed from description
> 
> We need to poll for a bit in the status register to know the dma state.
> We are currently doing that in the driver hot path
> To avoid this using own variables.

It would be worthwhile to document these, down the line people may not
remeber the motivation


-- 
~Vinod

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 1/3] dmaengine: xilinx_dma: Check for channel idle  state before submitting dma descriptor Vinod Koul <vinod.koul@intel.com> - 2017-01-10 07:30 +0100
  Re: [PATCH v5 1/3] dmaengine: xilinx_dma: Check for channel idle  state before submitting dma descriptor Vinod Koul <vinod.koul@intel.com> - 2017-01-13 06:40 +0100

csiph-web