Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1556962

Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter

Show all headers | View raw

On Tue, 2017-01-10 at 23:58 +0100, Adam Borowski wrote:
> On Tue, Jan 10, 2017 at 10:28:38PM +0100, Manuel Schölling wrote:
> > The impact of the persistent scrollback feature on the code size is
> > rather small, so the config option is removed. The feature stays
> > disabled by default and can be enabled by using the boot command
> > line
> > parameter 'vgacon.scrollback_persistent=1' or by setting
> > VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y.
> > 
> > Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
> > Suggested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > +module_param_named(scrollback_persistent, scrollback_persistent,
> > bool, 0000);
> > +MODULE_PARM_DESC(scrollback_persistent, "Enable persistent
> > scrollback for all vga consoles");
> 
> A command-line knob settable by the end-user is something more
> persistent
> than a config option.  As you're going to extend this code beyond
> vgacon in
> the near future, perhaps it'd be better to have a shared setting for
> all
> console drivers?
Probably a good idea, but I'm struggling with the implementation a bit:

I tried to run 

  if (strstr(boot_command_line, "nopersistentscrollback")) {...}

in vgacon_scrollback_startup() but I am getting 

  WARNING: modpost: Found 2 section mismatch(es).

when compiling. Probably because vgacon_scrollback_startup() is
executed after init.

I tried to find another way to implement a boot cmd line parameter but
had no luck.
If you/somebody could point me in the right direction, it would be very
much appreciated.

Thanks!

Manuel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v9 4/4] console: Make persistent scrollback a boot parameter Manuel Schölling <manuel.schoelling@gmx.de> - 2017-01-10 22:40 +0100
  Re: [PATCH v9 4/4] console: Make persistent scrollback a boot  parameter Adam Borowski <kilobyte@angband.pl> - 2017-01-11 00:10 +0100
    Re: [PATCH v9 4/4] console: Make persistent scrollback a boot  parameter Manuel Schölling <manuel.schoelling@gmx.de> - 2017-01-11 22:50 +0100
    Re: [PATCH v9 4/4] console: Make persistent scrollback a boot  parameter Manuel Schölling <manuel.schoelling@gmx.de> - 2017-01-13 21:10 +0100
      Re: [PATCH v9 4/4] console: Make persistent scrollback a boot  parameter Greg KH <gregkh@linuxfoundation.org> - 2017-01-14 08:30 +0100

csiph-web