Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1556879

[PATCH v2 1/3] Input: pwm-beeper: suppress error message on probe defer

From David Lechner <david@lechnology.com>
Newsgroups linux.kernel
Subject [PATCH v2 1/3] Input: pwm-beeper: suppress error message on probe defer
Date 2017-01-11 21:10 +0100
Message-ID <sYxnz-2Us-17@gated-at.bofh.it> (permalink)
References <sYxnz-2Us-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


This suppress printing an error message when pwm_get returns -EPROBE_DEFER.
Otherwise you get a bunch of noise in the kernel log.

Signed-off-by: David Lechner <david@lechnology.com>
---
 drivers/input/misc/pwm-beeper.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
index ce6eec4..30ac227 100644
--- a/drivers/input/misc/pwm-beeper.c
+++ b/drivers/input/misc/pwm-beeper.c
@@ -104,9 +104,10 @@ static int pwm_beeper_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	beeper->pwm = devm_pwm_get(dev, NULL);
-	if (IS_ERR(beeper->pwm)) {
-		error = PTR_ERR(beeper->pwm);
-		dev_err(dev, "Failed to request pwm device: %d\n", error);
+	error = PTR_ERR_OR_ZERO(beeper->pwm);
+	if (error) {
+		if (error != -EPROBE_DEFER)
+			dev_err(dev, "Failed to request pwm device\n");
 		return error;
 	}
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/3] Input: add optional amplifier regulator to pwm-beeper​ (previously "Input: add optional enable gpio to pwm-beeper​") David Lechner <david@lechnology.com> - 2017-01-11 21:10 +0100
  [PATCH v2 1/3] Input: pwm-beeper: suppress error message on probe defer David Lechner <david@lechnology.com> - 2017-01-11 21:10 +0100
    Re: [PATCH v2 1/3] Input: pwm-beeper: suppress error message on  probe defer Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-14 20:20 +0100
  [PATCH v2 2/3] dt-bindings: Input: Add optional amp-supply property to pwm-beeper David Lechner <david@lechnology.com> - 2017-01-11 21:10 +0100
  [PATCH v2 3/3] Input: pwm-beeper: add optional amplifier regulator David Lechner <david@lechnology.com> - 2017-01-11 21:10 +0100
    Re: [PATCH v2 3/3] Input: pwm-beeper: add optional amplifier  regulator Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-14 20:20 +0100
      Re: [PATCH v2 3/3] Input: pwm-beeper: add optional amplifier  regulator David Lechner <david@lechnology.com> - 2017-01-16 01:20 +0100
        Re: [PATCH v2 3/3] Input: pwm-beeper: add optional amplifier  regulator Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-16 01:40 +0100
          Re: [PATCH v2 3/3] Input: pwm-beeper: add optional amplifier  regulator David Lechner <david@lechnology.com> - 2017-01-16 02:10 +0100

csiph-web