Re: [PATCH 1/2] capability: export has_capability

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Alex Williamson <alex.williamson@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] capability: export has_capability
Date	Wed, 11 Jan 2017 19:50:02 +0100
Message-ID	<sYw8a-1XP-29@gated-at.bofh.it> (permalink)
References	<sQKhX-Uh-13@gated-at.bofh.it> <sQKhX-Uh-11@gated-at.bofh.it>
X-Original-To	Jike Song <jike.song@intel.com>
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.22
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 11 Jan 2017 18:47:02 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	serge@hallyn.com, linux-security-module@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kwankhede@nvidia.com, kraxel@redhat.com
X-Original-Date	Wed, 11 Jan 2017 13:47:01 -0500
X-Original-Message-ID	<20170111134701.7d153d34@t450s.home>
X-Original-References	<1482336616-19252-1-git-send-email-jike.song@intel.com> <1482336616-19252-2-git-send-email-jike.song@intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1556839

Show key headers only | View raw

On Thu, 22 Dec 2016 00:10:15 +0800
Jike Song <jike.song@intel.com> wrote:

> has_capability() is sometimes needed by modules to test capability
> for specified task other than current, so export it.
> 
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Kirti Wankhede <kwankhede@nvidia.com>
> Signed-off-by: Jike Song <jike.song@intel.com>
> ---
>  kernel/capability.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/capability.c b/kernel/capability.c
> index 4984e1f..e2e198c 100644
> --- a/kernel/capability.c
> +++ b/kernel/capability.c
> @@ -318,6 +318,7 @@ bool has_capability(struct task_struct *t, int cap)
>  {
>  	return has_ns_capability(t, &init_user_ns, cap);
>  }
> +EXPORT_SYMBOL(has_capability);
>  
>  /**
>   * has_ns_capability_noaudit - Does a task have a capability (unaudited)

Are we using EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL here to match the other
exports in this file?  We could use _GPL to match the expected caller
of this.


Serge,

Do you have any comments on this patch?  I'd be happy to pull it
through the vfio tree with an appropriate Ack.  Thanks,

Alex

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] capability: export has_capability Alex Williamson <alex.williamson@redhat.com> - 2017-01-11 19:50 +0100
  Re: [PATCH 1/2] capability: export has_capability Jike Song <jike.song@intel.com> - 2017-01-12 02:00 +0100
  Re: [PATCH 1/2] capability: export has_capability "Serge E. Hallyn" <serge@hallyn.com> - 2017-01-12 07:50 +0100

csiph-web