Re: [PATCH 1/2] drm: fix drm_vm for NOMMU builds

From	Benjamin Gaignard <benjamin.gaignard@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] drm: fix drm_vm for NOMMU builds
Date	2017-01-11 18:20 +0100
Message-ID	<sYuJ3-1dY-5@gated-at.bofh.it> (permalink)
References	<sYria-7uK-5@gated-at.bofh.it> <sYtWF-In-13@gated-at.bofh.it> <sYu6m-Lo-25@gated-at.bofh.it> <sYu6m-Lo-27@gated-at.bofh.it> <sYuzn-1aF-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2017-01-11 17:59 GMT+01:00 Arnd Bergmann <arnd@arndb.de>:
> On Wed, Jan 11, 2017 at 5:36 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
>> On Wed, Jan 11, 2017 at 5:33 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> CONFIG_DRM_VM=y
>>
>> Does randconfig just set this for fun, despite that it's a hidden
>> Kconfig symbol? Should we add a depends !NOMMU to it to make sure it
>> never gets enabled when it shouldn't be?
>>
>> tbh I have no idea how Kconfig works, I'm just really good at breaking it :(
>
> no, randconfig won't try to set symbols that a user doesn't see. This
> is what 'menuconfig'
> says enabled it.
>
>   │   Selected by: DRM_NOUVEAU [=n] && HAS_IOMEM [=y] && DRM [=y] &&
> PCI [=n] && MMU [=n] && (BACKLIGHT_CLASS_DEVICE [=m] || !ACPI) ||
> DRM_LEGACY [=y] && HAS_IOMEM [=y] && DRM [=y]
>
> It must be the 'DRM_LEGACY' option that is actually user visible and
> that contains
> 'select DRM_VM'.

We should add "MMU" on DRM_LEGACY and DRM_VM dependencies
to be sure that they won't be select without MMU support

>
>      Arnd



-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] drm: fix drm_vm for NOMMU builds Arnd Bergmann <arnd@arndb.de> - 2017-01-11 14:40 +0100
  [PATCH 2/2] drm: add more MMU dependencies Arnd Bergmann <arnd@arndb.de> - 2017-01-11 14:40 +0100
    Re: [PATCH 2/2] drm: add more MMU dependencies Lucas Stach <l.stach@pengutronix.de> - 2017-01-11 15:10 +0100
      Re: [PATCH 2/2] drm: add more MMU dependencies Daniel Vetter <daniel@ffwll.ch> - 2017-01-11 17:30 +0100
  Re: [PATCH 1/2] drm: fix drm_vm for NOMMU builds Daniel Vetter <daniel@ffwll.ch> - 2017-01-11 17:30 +0100
    Re: [PATCH 1/2] drm: fix drm_vm for NOMMU builds Arnd Bergmann <arnd@arndb.de> - 2017-01-11 17:40 +0100
      Re: [PATCH 1/2] drm: fix drm_vm for NOMMU builds Daniel Vetter <daniel@ffwll.ch> - 2017-01-11 17:40 +0100
        Re: [PATCH 1/2] drm: fix drm_vm for NOMMU builds Arnd Bergmann <arnd@arndb.de> - 2017-01-11 18:10 +0100
          Re: [PATCH 1/2] drm: fix drm_vm for NOMMU builds Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-01-11 18:20 +0100

csiph-web