Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1556691

Re: [PATCH] ALSA: hda/ca0132 - fix possible NULL pointer use

Show all headers | View raw

On Wed, 11 Jan 2017 14:39:44 +0100,
Arnd Bergmann wrote:
> 
> gcc-7 caught what it considers a NULL pointer dereference:
> 
> sound/pci/hda/patch_ca0132.c: In function 'dspio_scp.constprop':
> sound/pci/hda/patch_ca0132.c:1487:4: error: argument 1 null where non-null expected [-Werror=nonnull]
> 
> This is plausible from looking at the function, as we compare 'reply'
> to NULL earlier in it. I have not tried to analyze if there are constraints
> that make it impossible to hit the bug, but adding another NULL check in
> the end kills the warning and makes the function more robust.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks.


Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ALSA: hda/ca0132 - fix possible NULL pointer use Arnd Bergmann <arnd@arndb.de> - 2017-01-11 14:50 +0100
  Re: [PATCH] ALSA: hda/ca0132 - fix possible NULL pointer use Takashi Iwai <tiwai@suse.de> - 2017-01-11 17:30 +0100

csiph-web