Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1556528

Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better

From Johannes Berg <johannes@sipsolutions.net>
Newsgroups linux.kernel
Subject Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better
Date 2017-01-11 15:40 +0100
Message-ID <sYsed-82P-11@gated-at.bofh.it> (permalink)
References <sYsed-82P-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, 2017-01-11 at 15:35 +0100, Arnd Bergmann wrote:
> gcc-7 complains that wl3501_cs passes NULL into a function that
> then uses the argument as the input for memcpy:
> 
> drivers/net/wireless/wl3501_cs.c: In function 'wl3501_get_scan':
> include/net/iw_handler.h:559:3: error: argument 2 null where non-null 
> expected [-Werror=nonnull]
>    memcpy(stream + point_len, extra, iwe->u.data.length);

I love wext ;-)

> This works fine here because iwe->u.data.length is guaranteed to be
> NULL, and the memcpy doesn't actually have an effect.

I think you mean 0, not NULL, but I can fix that when I apply it.

johannes

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] wext: handle NULL exta data in iwe_stream_add_point better Arnd Bergmann <arnd@arndb.de> - 2017-01-11 15:40 +0100
  Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point  better Johannes Berg <johannes@sipsolutions.net> - 2017-01-11 15:40 +0100
    Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better Arnd Bergmann <arnd@arndb.de> - 2017-01-11 16:10 +0100
      Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point  better Johannes Berg <johannes@sipsolutions.net> - 2017-01-11 16:10 +0100
        Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better Arnd Bergmann <arnd@arndb.de> - 2017-01-11 21:50 +0100
          Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point  better Johannes Berg <johannes@sipsolutions.net> - 2017-01-12 09:40 +0100
            Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point  better Johannes Berg <johannes@sipsolutions.net> - 2017-01-12 10:20 +0100
          Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point  better Johannes Berg <johannes@sipsolutions.net> - 2017-01-12 10:20 +0100
            Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better Arnd Bergmann <arnd@arndb.de> - 2017-01-12 10:50 +0100

csiph-web