Re: [PATCHv3 3/8] rtc: add STM32 RTC driver

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv3 3/8] rtc: add STM32 RTC driver
Date	2017-01-11 12:00 +0100
Message-ID	<sYoNk-5Rd-21@gated-at.bofh.it> (permalink)
References	(1 earlier) <sWgAy-3JT-29@gated-at.bofh.it> <sYeEh-88l-5@gated-at.bofh.it> <sYo0V-5B1-3@gated-at.bofh.it> <sYoaC-5E8-19@gated-at.bofh.it> <sYoDE-5NZ-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/01/2017 at 11:42:50 +0100, Amelie DELAUNAY wrote :
> 
> On 01/11/2017 11:17 AM, Alexandre Belloni wrote:
> > On 11/01/2017 at 11:07:16 +0100, Amelie DELAUNAY wrote :
> > > > This will never happen, tm is already checked multiple times (up to
> > > > three) in the core before this function can be called.
> > > > 
> > > You're right. I'll remove all rtc_valid_tm calls.
> > 
> > You can keep the one in read_time
> > 
> Even if rtc_valid_tm is called just after rtc->ops->read_time() in
> __rtc_read_time ?

Ah yes, I forgot it was added, you can remove all of them.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv3 3/8] rtc: add STM32 RTC driver Amelie Delaunay <amelie.delaunay@st.com> - 2017-01-05 14:50 +0100
  Re: [PATCHv3 3/8] rtc: add STM32 RTC driver Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-01-05 18:40 +0100
    Re: [PATCHv3 3/8] rtc: add STM32 RTC driver Amelie DELAUNAY <amelie.delaunay@st.com> - 2017-01-09 17:50 +0100
  Re: [PATCHv3 3/8] rtc: add STM32 RTC driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-01-11 01:10 +0100
    Re: [PATCHv3 3/8] rtc: add STM32 RTC driver Amelie DELAUNAY <amelie.delaunay@st.com> - 2017-01-11 11:10 +0100
      Re: [PATCHv3 3/8] rtc: add STM32 RTC driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-01-11 11:20 +0100
        Re: [PATCHv3 3/8] rtc: add STM32 RTC driver Amelie DELAUNAY <amelie.delaunay@st.com> - 2017-01-11 11:50 +0100
          Re: [PATCHv3 3/8] rtc: add STM32 RTC driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-01-11 12:00 +0100

csiph-web