Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

From	Julia Lawall <julia.lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user
Date	2017-01-11 07:20 +0100
Message-ID	<sYkql-3ef-1@gated-at.bofh.it> (permalink)
References	(3 earlier) <sY0hX-7uT-5@gated-at.bofh.it> <sY0hX-7uT-3@gated-at.bofh.it> <sY8Iy-4hr-45@gated-at.bofh.it> <sY8Iy-4hr-43@gated-at.bofh.it> <sYkql-3ef-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

I looked at the get_user part of the original script.  It looks like most
of the complexity is to deal with the possibility of the src location
being expressed in two different ways between the two calls.  Even if this
happens in practice only for get_user, it would seem that it could happen
for copy_from_user as well.  So I think we could just throw both get_user
and copy_from_user into the same rule?

I'm also not sure to understand why there are cases for things like

get_user(exp1, src->f1)
...
get_user(exp2,src)

Can this happen?  The types seem wrong.

Likewise, I see the need to take into account a second argument of src++,
but not the need to take into account a second argument of src+4.  Either
there is src+4 in both calls or the addresses involved are just different.

Perhaps I'm missing something, though.

julia

Thread

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user Vaishali Thakkar <vaishali.thakkar@oracle.com> - 2017-01-09 18:10 +0100
  Re: [Cocci] [PATCH] coccicheck: add a test for repeat  copy_from_user Julia Lawall <julia.lawall@lip6.fr> - 2017-01-09 20:20 +0100
    Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user Kees Cook <keescook@chromium.org> - 2017-01-09 22:00 +0100
      Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user Kees Cook <keescook@chromium.org> - 2017-01-09 23:10 +0100
  Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user Vaishali Thakkar <vaishali.thakkar@oracle.com> - 2017-01-10 09:50 +0100
    Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user Vaishali Thakkar <vaishali.thakkar@oracle.com> - 2017-01-10 18:50 +0100
      Re: [Cocci] [PATCH] coccicheck: add a test for repeat  copy_from_user Julia Lawall <julia.lawall@lip6.fr> - 2017-01-11 07:20 +0100
        Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user Pengfei Wang <wpengfeinudt@gmail.com> - 2017-01-11 14:50 +0100
    Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user Kees Cook <keescook@chromium.org> - 2017-01-10 20:20 +0100
  Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user Kees Cook <keescook@chromium.org> - 2017-01-10 20:20 +0100

csiph-web