Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1556199

Re: [PATCH] selftests/futex: Fix makefile dependencies

Show all headers | View raw

On Tue, Jan 10, 2017 at 02:17:18PM -0800, Darren Hart wrote:
> On Tue, Jan 10, 2017 at 02:10:42PM -0800, Darren Hart wrote:
> > On Fri, Jan 06, 2017 at 01:18:39PM +0900, Stafford Horne wrote:
> > > I am working on doing selftests for openrisc and found issues with the
> > > futex test is not building after changes to the tests source.
> > > 
> > > This issue is that the TARGETS variable used in the futex Makefile is
> > > also used by the selftests Makefile, so when building from toplevel the
> > > TARGETS variable is clobbered and nothing gets built. Changed the
> > > variable name to get around that.
> > > 
> > > Also, the futex makefile did not contain dependencies for all headers,
> > > so if we make changes to logging.h rebuild will not happen. Add headers
> > > to fix it up.
> > > 
> > > Signed-off-by: Stafford Horne <shorne@gmail.com>
> > 
> > Thanks for catching this and the fix.
> > 
> > +Shuah Khan
> > 
> > Note: This appears also to be a problem for intel_pstate/Makefile
> 
> Or, it would be if intel_pstate was listed in selftests/Makefile :-)

Right, thanks for having a look.  I actually have a small patch to also
add <stdio.h> to logging.h.  If you have not already fixed the
intel_pstate test I'll send them all together.

Although I am working on testing openrisc, doing a intel_pstate test on
my box shouldnt be much of a problem :)

-Stafford

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] selftests/futex: Fix makefile dependencies Stafford Horne <shorne@gmail.com> - 2017-01-06 05:30 +0100
  Re: [PATCH] selftests/futex: Fix makefile dependencies Darren Hart <dvhart@infradead.org> - 2017-01-10 23:20 +0100
    Re: [PATCH] selftests/futex: Fix makefile dependencies Stafford Horne <shorne@gmail.com> - 2017-01-11 05:40 +0100
      Re: [PATCH] selftests/futex: Fix makefile dependencies Darren Hart <dvhart@infradead.org> - 2017-01-11 09:10 +0100
        Re: [PATCH] selftests/futex: Fix makefile dependencies Stafford Horne <shorne@gmail.com> - 2017-01-11 09:50 +0100
          Re: [PATCH] selftests/futex: Fix makefile dependencies Shuah Khan <shuah@kernel.org> - 2017-01-11 15:50 +0100
            Re: [PATCH] selftests/futex: Fix makefile dependencies Stafford Horne <shorne@gmail.com> - 2017-01-11 16:40 +0100
  Re: [PATCH] selftests/futex: Fix makefile dependencies Darren Hart <dvhart@infradead.org> - 2017-01-10 23:20 +0100

csiph-web