Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1556167
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next 5/8] net: dsa: Export dev_to_net_device() |
| Date | 2017-01-11 03:30 +0100 |
| Message-ID | <sYgPL-Vm-5@gated-at.bofh.it> (permalink) |
| References | <sYb3H-5OA-15@gated-at.bofh.it> <sYb3H-5OA-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 10 Jan 2017 12:12:32 -0800
> @@ -491,7 +491,7 @@ struct mii_bus *dsa_host_dev_to_mii_bus(struct device *dev)
> }
> EXPORT_SYMBOL_GPL(dsa_host_dev_to_mii_bus);
>
> -static struct net_device *dev_to_net_device(struct device *dev)
> +struct net_device *dev_to_net_device(struct device *dev)
> {
> struct device *d;
>
> @@ -508,6 +508,7 @@ static struct net_device *dev_to_net_device(struct device *dev)
>
> return NULL;
> }
> +EXPORT_SYMBOL_GPL(dev_to_net_device);
Something like this, a public interface with a very high level generic name,
doesn't belong in the DSA layer. It belongs in net/core/dev.c or something
like that.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next 0/8] net: dsa: Support for pdata in dsa2 Florian Fainelli <f.fainelli@gmail.com> - 2017-01-10 21:20 +0100
[PATCH net-next 6/8] net: dsa: Add support for platform data Florian Fainelli <f.fainelli@gmail.com> - 2017-01-10 21:20 +0100
Re: [PATCH net-next 6/8] net: dsa: Add support for platform data Andrew Lunn <andrew@lunn.ch> - 2017-01-10 21:50 +0100
Re: [PATCH net-next 6/8] net: dsa: Add support for platform data Florian Fainelli <f.fainelli@gmail.com> - 2017-01-10 22:10 +0100
Re: [PATCH net-next 6/8] net: dsa: Add support for platform data Andrew Lunn <andrew@lunn.ch> - 2017-01-10 22:30 +0100
Re: [PATCH net-next 6/8] net: dsa: Add support for platform data Florian Fainelli <f.fainelli@gmail.com> - 2017-01-10 23:20 +0100
[PATCH net-next 7/8] net: phy: Allow pre-declaration of MDIO devices Florian Fainelli <f.fainelli@gmail.com> - 2017-01-10 21:20 +0100
[PATCH net-next 5/8] net: dsa: Export dev_to_net_device() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-10 21:20 +0100
Re: [PATCH net-next 5/8] net: dsa: Export dev_to_net_device() David Miller <davem@davemloft.net> - 2017-01-11 03:30 +0100
[PATCH net-next 1/8] net: dsa: Pass device pointer to dsa_register_switch Florian Fainelli <f.fainelli@gmail.com> - 2017-01-10 21:20 +0100
[PATCH net-next 3/8] net: dsa: Suffix function manipulating device_node with _dn Florian Fainelli <f.fainelli@gmail.com> - 2017-01-10 21:20 +0100
[PATCH net-next 4/8] net: dsa: Move ports assignment closer to error checking Florian Fainelli <f.fainelli@gmail.com> - 2017-01-10 21:20 +0100
[PATCH net-next 2/8] net: dsa: Make most functions take a dsa_port argument Florian Fainelli <f.fainelli@gmail.com> - 2017-01-10 21:20 +0100
csiph-web