Re: [PATCH v4 0/4] Introduce the initify gcc plugin

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 0/4] Introduce the initify gcc plugin
Date	2017-01-11 02:10 +0100
Message-ID	<sYfAm-fa-13@gated-at.bofh.it> (permalink)
References	<sP8Rs-Yj-29@gated-at.bofh.it> <sP918-11E-17@gated-at.bofh.it> <sQ493-70A-11@gated-at.bofh.it> <sVHCN-5tw-9@gated-at.bofh.it> <sYeXD-8ep-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 10, 2017 at 4:24 PM, Emese Revfy <re.emese@gmail.com> wrote:
> On Tue, 3 Jan 2017 16:23:03 -0800
> Kees Cook <keescook@chromium.org> wrote:
>
>> On Mon, Dec 19, 2016 at 3:10 AM, Emese Revfy <re.emese@gmail.com> wrote:
>> > On Fri, 16 Dec 2016 14:19:10 -0800
>> > Kees Cook <keescook@chromium.org> wrote:
>> >
>> >> FWIW, it still seems to me that these aren't false positives:
>> >>
>> >> WARNING: vmlinux.o(.text.unlikely+0x1b1): Section mismatch in
>> >> reference from the function uncore_pci_exit.part.22() to the function
>> >> .init.text:uncore_free_pcibus_map()
>> >> The function uncore_pci_exit.part.22() references
>> >> the function __init uncore_free_pcibus_map().
>> >> This is often because uncore_pci_exit.part.22 lacks a __init
>> >> annotation or the annotation of uncore_free_pcibus_map is wrong.
>
> Thanks for the report, you can find the fix here:
> https://github.com/ephox-gcc-plugins/initify/commit/5d93a54badd9751b79ef67ce8a8b4081fea37547

Awesome! Thanks, that eliminated almost all of the warnings. I'm still
seeing this:

WARNING: vmlinux.o(.text+0x1087e7): Section mismatch in reference from
the function rebind_subsystems() to the variable
.init.rodata.str:__func__.4400
The function rebind_subsystems() references
the variable __initconst __func__.4400.
This is often because rebind_subsystems lacks a __initconst
annotation or the annotation of __func__.4400 is wrong.

WARNING: vmlinux.o(.text+0x13789d): Section mismatch in reference from
the function register_ftrace_export() to the variable
.init.rodata.str:__func__.4251
The function register_ftrace_export() references
the variable __initconst __func__.4251.
This is often because register_ftrace_export lacks a __initconst
annotation or the annotation of __func__.4251 is wrong.

WARNING: vmlinux.o(.text+0x139d24): Section mismatch in reference from
the function tracepoint_printk_sysctl() to the variable
.init.rodata.str:__func__.4251
The function tracepoint_printk_sysctl() references
the variable __initconst __func__.4251.
This is often because tracepoint_printk_sysctl lacks a __initconst
annotation or the annotation of __func__.4251 is wrong.

I haven't taken a close look yet, but I assume these are from the
const strings in these functions?

-Kees

-- 
Kees Cook
Nexus Security

Thread

Re: [PATCH v4 0/4] Introduce the initify gcc plugin Emese Revfy <re.emese@gmail.com> - 2017-01-11 01:30 +0100
  Re: [PATCH v4 0/4] Introduce the initify gcc plugin Kees Cook <keescook@chromium.org> - 2017-01-11 02:10 +0100
    Re: [PATCH v4 0/4] Introduce the initify gcc plugin Emese Revfy <re.emese@gmail.com> - 2017-01-12 22:50 +0100
      Re: [PATCH v4 0/4] Introduce the initify gcc plugin Kees Cook <keescook@chromium.org> - 2017-01-13 00:30 +0100
        Re: [PATCH v4 0/4] Introduce the initify gcc plugin Kees Cook <keescook@chromium.org> - 2017-01-13 00:50 +0100

csiph-web