Re: [PATCH v4 01/10] power: supplies: bq27xxx: rename BQ27500 allow for deprecation in future.

From	Sebastian Reichel <sre@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 01/10] power: supplies: bq27xxx: rename BQ27500 allow for deprecation in future.
Date	2017-01-11 00:30 +0100
Message-ID	<sYe1z-7Gf-7@gated-at.bofh.it> (permalink)
References	<sR0mJ-2AR-5@gated-at.bofh.it> <sXXap-5IN-3@gated-at.bofh.it> <sXXk5-5LU-1@gated-at.bofh.it> <sY0rE-7yf-19@gated-at.bofh.it> <sYd5v-74s-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Wed, Jan 11, 2017 at 09:25:01AM +1100, Chris Lapa wrote:
> On 10/1/17 7:58 pm, Pali Rohár wrote:
> > On Tuesday 10 January 2017 16:25:29 Chris Lapa wrote:
> > > From: Chris Lapa <chris@lapa.com.au>
> > > 
> > > The BQ275XX definition exists only to satisfy backwards compatibility.
> > > 
> > > tested: yes
> > 
> > Instead "tested: yes" we use: "Tested-by: name <email>" line.
> > 
> > > Signed-off-by: Chris Lapa <chris@lapa.com.au>
> > > Acked-by: Pali Rohár <pali.rohar@gmail.com>
> > > Reviewed-by: Andrew F. Davis <afd@ti.com>
> > 
> 
> Doh, I went through the log and thought I saw 'tested: yes' being used
> previously. Want me to resend?

If a respin is needed, please fix it. Also the patches still use
"supplies" instead of "supply" in the patch subject. I would have
fixed this while applying, but this (PATCH 1/10) actually looks
fishy to me:

> -       { "bq27500", BQ27500 },
> -       { "bq27510", BQ27510 },
> -       { "bq27520", BQ27510 },
> +       { "bq27500", BQ275XX },
> +       { "bq27510", BQ275XX },
> +       { "bq27520", BQ275XX },

Previously bq27500 and bq27510/bq27520 had different type ids,
while after the patch both use the same. The patch description
does not mention why this is ok and it actually looks incorrect.
I guess we need to introduce BQ2750X and BQ2751X for backwards
compatibility instead?

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 00/10] power: supply: bq27xxx: implement individual chip revision support Chris Lapa <chris@lapa.com.au> - 2017-01-10 06:30 +0100
  [PATCH v4 08/10] power: supplies: bq27xxx: adds specific support for bq27520-g3 revision. Chris Lapa <chris@lapa.com.au> - 2017-01-10 06:30 +0100
  [PATCH v4 06/10] power: supplies: bq27xxx: adds specific support for bq27520-g1 revision. Chris Lapa <chris@lapa.com.au> - 2017-01-10 06:30 +0100
  [PATCH v4 01/10] power: supplies: bq27xxx: rename BQ27500 allow for deprecation in future. Chris Lapa <chris@lapa.com.au> - 2017-01-10 06:40 +0100
    Re: [PATCH v4 01/10] power: supplies: bq27xxx: rename BQ27500 allow  for deprecation in future. Pali Rohár <pali.rohar@gmail.com> - 2017-01-10 10:00 +0100
      Re: [PATCH v4 01/10] power: supplies: bq27xxx: rename BQ27500 allow  for deprecation in future. Chris Lapa <chris@lapa.com.au> - 2017-01-10 23:30 +0100
        Re: [PATCH v4 01/10] power: supplies: bq27xxx: rename BQ27500 allow  for deprecation in future. Sebastian Reichel <sre@kernel.org> - 2017-01-11 00:30 +0100

csiph-web