Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1556005
| From | Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH V7 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path |
| Date | 2017-01-11 00:30 +0100 |
| Message-ID | <sYe1A-7Gf-35@gated-at.bofh.it> (permalink) |
| References | <sYe1z-7Gf-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
ldio outstanding variable needs to be decremented in io completion path for
iMR dual queue depth
Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
---
Changes v6 -> v7:
-None
drivers/scsi/megaraid/megaraid_sas_fusion.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 4d655e4..705102f 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -2580,7 +2580,6 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
if (atomic_inc_return(&instance->fw_outstanding) >
instance->host->can_queue) {
- dev_err(&instance->pdev->dev, "Throttle IOs beyond Controller queue depth\n");
atomic_dec(&instance->fw_outstanding);
return SCSI_MLQUEUE_HOST_BUSY;
}
@@ -2811,6 +2810,9 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
extStatus, data_length, sense);
scsi_io_req->RaidContext.raid_context.status = 0;
scsi_io_req->RaidContext.raid_context.ex_status = 0;
+ if (instance->ldio_threshold
+ && megasas_cmd_type(scmd_local) == READ_WRITE_LDIO)
+ atomic_dec(&instance->ldio_outstanding);
megasas_return_cmd_fusion(instance, cmd_fusion);
scsi_dma_unmap(scmd_local);
scmd_local->scsi_done(scmd_local);
@@ -3959,7 +3961,8 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
scmd_local->result =
megasas_check_mpio_paths(instance,
scmd_local);
- if (megasas_cmd_type(scmd_local) == READ_WRITE_LDIO)
+ if (instance->ldio_threshold &&
+ megasas_cmd_type(scmd_local) == READ_WRITE_LDIO)
atomic_dec(&instance->ldio_outstanding);
megasas_return_cmd_fusion(instance, cmd_fusion);
scsi_dma_unmap(scmd_local);
--
1.8.3.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V7 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com> - 2017-01-11 00:30 +0100 [PATCH V7 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com> - 2017-01-11 00:30 +0100 [PATCH V7 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com> - 2017-01-11 00:30 +0100 [PATCH V7 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com> - 2017-01-11 00:30 +0100 [PATCH V7 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com> - 2017-01-11 00:30 +0100 [PATCH V7 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com> - 2017-01-11 00:30 +0100 [PATCH V7 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com> - 2017-01-11 00:30 +0100 [PATCH V7 02/11] megaraid_sas: 128 MSIX Support Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com> - 2017-01-11 00:30 +0100 [PATCH V7 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com> - 2017-01-11 00:30 +0100 [PATCH V7 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com> - 2017-01-11 00:30 +0100 Re: [PATCH V7 00/11] megaraid_sas: Updates for scsi-next "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-01-11 05:20 +0100
csiph-web