Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1555981

Re: [PATCH v2 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

From Andi Shyti <andi.shyti@samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC
Date 2017-01-10 23:50 +0100
Message-ID <sYdoR-7d0-3@gated-at.bofh.it> (permalink)
References <sYdoR-7d0-5@gated-at.bofh.it> <sY3pw-1at-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Sean,

>    include/linux/compiler.h:253:8: sparse: attribute 'no_sanitize_address': unknown attribute
> >> drivers/media/rc/mtk-cir.c:215:41: sparse: too many arguments for function devm_rc_allocate_device
>    drivers/media/rc/mtk-cir.c: In function 'mtk_ir_probe':
>    drivers/media/rc/mtk-cir.c:215:11: error: too many arguments to function 'devm_rc_allocate_device'
>      ir->rc = devm_rc_allocate_device(dev, RC_DRIVER_IR_RAW);
>               ^~~~~~~~~~~~~~~~~~~~~~~
>    In file included from drivers/media/rc/mtk-cir.c:22:0:
>    include/media/rc-core.h:213:16: note: declared here
>     struct rc_dev *devm_rc_allocate_device(struct device *dev);
>                    ^~~~~~~~~~~~~~~~~~~~~~~
> 
> vim +/devm_rc_allocate_device +215 drivers/media/rc/mtk-cir.c
> 
>    209		ir->base = devm_ioremap_resource(dev, res);
>    210		if (IS_ERR(ir->base)) {
>    211			dev_err(dev, "failed to map registers\n");
>    212			return PTR_ERR(ir->base);
>    213		}
>    214	
>  > 215		ir->rc = devm_rc_allocate_device(dev, RC_DRIVER_IR_RAW);

this error comes because the patches I pointed out have not been
applied yet. I guess you can ignore them as long as you tested
yours on top those patches.

Andi

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2 2/2] media: rc: add driver for IR remote receiver on  MT7623 SoC Andi Shyti <andi.shyti@samsung.com> - 2017-01-10 23:50 +0100
  Re: [PATCH v2 2/2] media: rc: add driver for IR remote receiver on  MT7623 SoC Sean Wang <sean.wang@mediatek.com> - 2017-01-11 10:30 +0100

csiph-web