Re: [PATCH 0/2] Style fixes: open code obfuscating macros

From	Jon Mason <jdmason@kudzu.us>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/2] Style fixes: open code obfuscating macros
Date	2017-01-10 23:00 +0100
Message-ID	<sYcCt-6CS-13@gated-at.bofh.it> (permalink)
References	<sVmeZ-7gO-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 02, 2017 at 06:30:34PM -0700, Logan Gunthorpe wrote:
> Hi,
> 
> I had copied some poor code style from the NTB drivers into an unrelated
> driver. Upon review of my new code, I learned it was not a good idea
> to sweep dirty things under the rug^W macro. See [1], where Gregg k-h
> suggested I fix the problem at the source.
> 
> Thus, please merge the following two patches to improve the style of
> the NTB drivers.
> 
> Thanks,
> 
> Logan

Applying the series, thanks

> 
> [1] http://www.spinics.net/lists/linux-pci/msg56904.html
> 
> 
> Logan Gunthorpe (2):
>   ntb_hw_amd: Style fixes: open code macros that just obfuscate code
>   ntb_hw_intel: Style fixes: open code macros that just obfuscate code
> 
>  drivers/ntb/hw/amd/ntb_hw_amd.c     |  59 ++++++++-------
>  drivers/ntb/hw/amd/ntb_hw_amd.h     |   3 -
>  drivers/ntb/hw/intel/ntb_hw_intel.c | 145 ++++++++++++++++++------------------
>  drivers/ntb/hw/intel/ntb_hw_intel.h |   3 -
>  4 files changed, 104 insertions(+), 106 deletions(-)
> 
> --
> 2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 0/2] Style fixes: open code obfuscating macros Jon Mason <jdmason@kudzu.us> - 2017-01-10 23:00 +0100
  Re: [PATCH 0/2] Style fixes: open code obfuscating macros Jon Mason <jdmason@kudzu.us> - 2017-01-10 23:20 +0100
    Re: [PATCH 0/2] Style fixes: open code obfuscating macros Joe Perches <joe@perches.com> - 2017-01-11 00:10 +0100
      Re: [PATCH 0/2] Style fixes: open code obfuscating macros Logan Gunthorpe <logang@deltatee.com> - 2017-01-11 00:40 +0100
        Re: [PATCH 0/2] Style fixes: open code obfuscating macros Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-11 08:00 +0100
          Re: [PATCH 0/2] Style fixes: open code obfuscating macros Logan Gunthorpe <logang@deltatee.com> - 2017-01-11 18:50 +0100

csiph-web