[PATCH] usb: dwc3-exynos remove suspend clock unspecified debug message

From	Shuah Khan <shuahkh@osg.samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH] usb: dwc3-exynos remove suspend clock unspecified debug message
Date	2017-01-10 22:30 +0100
Message-ID	<sYc9s-6qU-37@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

dwc3-exynos prints debug message when suspend clock is not specified.
The suspend clock is optional and driver can work without it.

This debug message doesn't add any value and leads to confusion and
concern. Remove it.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
This patch is a result of the disussion on the following patch.
https://lkml.org/lkml/2017/1/9/891

drivers/usb/dwc3/dwc3-exynos.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
index e27899b..3e8407a 100644
--- a/drivers/usb/dwc3/dwc3-exynos.c
+++ b/drivers/usb/dwc3/dwc3-exynos.c
@@ -128,10 +128,8 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
 	clk_prepare_enable(exynos->clk);
 
 	exynos->susp_clk = devm_clk_get(dev, "usbdrd30_susp_clk");
-	if (IS_ERR(exynos->susp_clk)) {
-		dev_info(dev, "no suspend clk specified\n");
+	if (IS_ERR(exynos->susp_clk))
 		exynos->susp_clk = NULL;
-	}
 	clk_prepare_enable(exynos->susp_clk);
 
 	if (of_device_is_compatible(node, "samsung,exynos7-dwusb3")) {
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: dwc3-exynos remove suspend clock unspecified debug message Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-10 22:30 +0100
  Re: [PATCH] usb: dwc3-exynos remove suspend clock unspecified debug  message Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-11 01:20 +0100
    Re: [PATCH] usb: dwc3-exynos remove suspend clock unspecified debug  message Shuah Khan <shuahkh@osg.samsung.com> - 2017-01-11 01:30 +0100

csiph-web