Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero

From	Bin Liu <b-liu@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero
Date	2017-01-10 21:30 +0100
Message-ID	<sYbdn-5RN-15@gated-at.bofh.it> (permalink)
References	<sWDns-31z-7@gated-at.bofh.it> <sYbdn-5RN-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 03, 2017 at 11:25:34PM +0800, Icenowy Zheng wrote:
> Lichee Pi Zero features a USB OTG port.
> 
> Add support for it.
> 
> Note: in order to use the Host mode, the board must be powered via the
> +5V and GND pins.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
>  arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts
> index 0099affc6ce3..3d9168cbaeca 100644
> --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts
> +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts
> @@ -71,3 +71,13 @@
>  	pinctrl-names = "default";
>  	status = "okay";
>  };
> +
> +&usb_otg {
> +	dr_mode = "otg";

Why not set this default mode in dtsi instead?

Regards,
-Bin.

> +	status = "okay";
> +};
> +
> +&usbphy {
> +	usb0_id_det-gpio = <&pio 5 6 GPIO_ACTIVE_HIGH>;
> +	status = "okay";
> +};
> -- 
> 2.11.0
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero Bin Liu <b-liu@ti.com> - 2017-01-10 21:30 +0100
  Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero Bin Liu <b-liu@ti.com> - 2017-01-11 21:20 +0100
    Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero Bin Liu <b-liu@ti.com> - 2017-01-11 21:40 +0100
    Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-01-11 22:20 +0100
      Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero Bin Liu <b-liu@ti.com> - 2017-01-12 16:00 +0100
        Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-01-12 19:10 +0100
          Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero Bin Liu <b-liu@ti.com> - 2017-01-13 22:10 +0100

csiph-web