Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1555833

Re: [linux-sunxi] Re: [PATCH 3/6] clk: sunxi-ng: Add H5 clocks

From Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [linux-sunxi] Re: [PATCH 3/6] clk: sunxi-ng: Add H5 clocks
Date 2017-01-10 20:20 +0100
Message-ID <sYa7D-5fe-7@gated-at.bofh.it> (permalink)
References <sYa7D-5fe-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Mon, Jan 09, 2017 at 09:13:12PM +0800, Icenowy Zheng wrote:
> 
> 2017年1月9日 下午7:01于 Maxime Ripard <maxime.ripard@free-electrons.com>写道:
> >
> > On Fri, Jan 06, 2017 at 06:48:31AM +0800, Icenowy Zheng wrote: 
> > > 
> > > 2017年1月6日 06:04于 Maxime Ripard <maxime.ripard@free-electrons.com>写道: 
> > > > 
> > > > On Tue, Dec 27, 2016 at 12:25:15AM +0800, Icenowy Zheng wrote: 
> > > > > Add the H5 CCU clocks set based on the H3 one. 
> > > > > 
> > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> 
> > > > 
> > > > Is there any difference with H3's? 
> > > 
> > > One more Transport Stream controller, so one more bus gate and bus 
> > > reset for it. 
> >
> > There's no need to duplicate more than 1000 lines of code just for 
> > that then. Just add a new compatible and reuse the clocks already 
> > defined. 
> 
> How can I do this? Add them in ccu-sun8i-h3.c ?

Yes, you can have a look at how I did it for sun5i for example if you
want.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [linux-sunxi] Re: [PATCH 3/6] clk: sunxi-ng: Add H5 clocks Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-01-10 20:20 +0100

csiph-web