Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1557900

Re: [PATCH net-next v2 05/10] drivers: base: Add device_find_class()

Show all headers | View raw

On 01/12/2017 01:21 PM, David Miller wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Wed, 11 Jan 2017 19:41:16 -0800
> 
>> Add a helper function to lookup a device reference given a class name.
>> This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and
>> make it more generic.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>>  drivers/base/core.c    | 19 +++++++++++++++++++
>>  include/linux/device.h |  1 +
>>  2 files changed, 20 insertions(+)
>>
>> diff --git a/drivers/base/core.c b/drivers/base/core.c
>> index 020ea7f05520..3dd6047c10d8 100644
>> --- a/drivers/base/core.c
>> +++ b/drivers/base/core.c
>> @@ -2065,6 +2065,25 @@ struct device *device_find_child(struct device *parent, void *data,
>>  }
>>  EXPORT_SYMBOL_GPL(device_find_child);
>>  
>> +static int dev_is_class(struct device *dev, void *class)
> 
> I know you are just moving code, but this class argumnet is a string
> and thus should be "char *" or even "const char *".

Well, this is really so that we don't need to cast the arguments passed
to device_find_child(), which takes a void *data as well. If we made
that a const char *class, we'd get warnings that look like these:

drivers/base/core.c: In function 'device_find_class':
drivers/base/core.c:2083:2: warning: passing argument 2 of
'device_find_child' discards 'const' qualifier from pointer target type
[enabled by default]
  return device_find_child(parent, class, dev_is_class);
  ^
drivers/base/core.c:2050:16: note: expected 'void *' but argument is of
type 'const char *'
 struct device *device_find_child(struct device *parent, void *data,
                ^
drivers/base/core.c:2083:2: warning: passing argument 3 of
'device_find_child' from incompatible pointer type [enabled by default]
  return device_find_child(parent, class, dev_is_class);
  ^
drivers/base/core.c:2050:16: note: expected 'int (*)(struct device *,
void *)' but argument is of type 'int (*)(struct device *, const char *)'
 struct device *device_find_child(struct device *parent, void *data,
                ^

-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next v2 00/10] net: dsa: Support for pdata in dsa2 Florian Fainelli <f.fainelli@gmail.com> - 2017-01-12 04:50 +0100
  [PATCH net-next v2 05/10] drivers: base: Add device_find_class() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-12 04:50 +0100
    Re: [PATCH net-next v2 05/10] drivers: base: Add  device_find_class() David Miller <davem@davemloft.net> - 2017-01-12 22:30 +0100
      Re: [PATCH net-next v2 05/10] drivers: base: Add device_find_class() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-13 00:00 +0100
        Re: [PATCH net-next v2 05/10] drivers: base: Add  device_find_class() David Miller <davem@davemloft.net> - 2017-01-13 05:20 +0100
        RE: [PATCH net-next v2 05/10] drivers: base: Add device_find_class() David Laight <David.Laight@ACULAB.COM> - 2017-01-13 12:00 +0100
          Re: [PATCH net-next v2 05/10] drivers: base: Add device_find_class() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-14 20:10 +0100
  [PATCH net-next v2 10/10] ARM: orion: Register DSA switch as a MDIO device Florian Fainelli <f.fainelli@gmail.com> - 2017-01-12 04:50 +0100
  [PATCH net-next v2 06/10] net: dsa: Migrate to device_find_class() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-12 04:50 +0100
  [PATCH net-next v2 04/10] net: dsa: Move ports assignment closer to error checking Florian Fainelli <f.fainelli@gmail.com> - 2017-01-12 04:50 +0100
  [PATCH net-next v2 01/10] net: dsa: Pass device pointer to dsa_register_switch Florian Fainelli <f.fainelli@gmail.com> - 2017-01-12 04:50 +0100
  [PATCH net-next v2 09/10] net: phy: Allow pre-declaration of MDIO devices Florian Fainelli <f.fainelli@gmail.com> - 2017-01-12 04:50 +0100
  Re: [PATCH net-next v2 00/10] net: dsa: Support for pdata in dsa2 Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-13 03:40 +0100

csiph-web