Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc
Date	2017-01-12 23:00 +0100
Message-ID	<sYVzB-GY-31@gated-at.bofh.it> (permalink)
References	<sYVgf-Ak-37@gated-at.bofh.it> <sYVpT-DA-13@gated-at.bofh.it> <sYVzA-GY-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Shannon Nelson <shannon.nelson@oracle.com>
Date: Thu, 12 Jan 2017 13:58:10 -0800

> 
> 
> On 1/12/2017 1:47 PM, David Miller wrote:
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Thu, 12 Jan 2017 13:36:30 -0800
>>
>>> val should be an union, so that proper alignment is enforced by one
>>> member.
>>
>> Sure, annotating the type so that it is aligned correctly makes
>> sense.
>>
> 
> ... and we should change the offending pointer assignment as well.  I
> can use this and respin a v2 if we're happy with this solution.

I am.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc Shannon Nelson <shannon.nelson@oracle.com> - 2017-01-12 21:00 +0100
  Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on  sparc Eric Dumazet <eric.dumazet@gmail.com> - 2017-01-12 21:20 +0100
    Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on  sparc Rob Gardner <rob.gardner@oracle.com> - 2017-01-12 21:20 +0100
      Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on  sparc Eric Dumazet <eric.dumazet@gmail.com> - 2017-01-12 21:30 +0100
        Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on  sparc David Miller <davem@davemloft.net> - 2017-01-12 21:40 +0100
        Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on  sparc Shannon Nelson <shannon.nelson@oracle.com> - 2017-01-12 21:40 +0100
          Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on  sparc David Miller <davem@davemloft.net> - 2017-01-12 21:50 +0100
            Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on  sparc Shannon Nelson <shannon.nelson@oracle.com> - 2017-01-12 22:00 +0100
              Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on  sparc David Miller <davem@davemloft.net> - 2017-01-12 22:20 +0100
                Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on  sparc Eric Dumazet <eric.dumazet@gmail.com> - 2017-01-12 22:40 +0100
                Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on  sparc David Miller <davem@davemloft.net> - 2017-01-12 22:50 +0100
                Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on  sparc Shannon Nelson <shannon.nelson@oracle.com> - 2017-01-12 23:00 +0100
                Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on  sparc David Miller <davem@davemloft.net> - 2017-01-12 23:00 +0100

csiph-web