Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1557828
| From | "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] tpm_tis: override reported C and D timeouts for Atmel 3203 |
| Date | 2017-01-12 22:40 +0100 |
| Message-ID | <sYVgf-Ak-27@gated-at.bofh.it> (permalink) |
| References | <sYS8H-7eZ-25@gated-at.bofh.it> <sYSBI-7oY-5@gated-at.bofh.it> <sYTR7-8jl-1@gated-at.bofh.it> <sYUau-8pV-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12.01.2017 21:20, Jarkko Sakkinen wrote: > On Thu, Jan 12, 2017 at 09:09:33PM +0100, Maciej S. Szmigiero wrote: >> Hi Jason, >> >> On 12.01.2017 19:42, Jason Gunthorpe wrote: (..) >>> Can you also add a check for 0 timeouts in the core code and print a >>> FW_BUG :\ >> >> Hmm, I dug in history of tpm-interface.c and the code had actually rejected >> zero timeouts until commit 8e54caf407b98e (this is the commit that >> introduced the Atmel 3204 workaround) and let default timeout values remain >> instead (it looks like they were exactly like these in above override at >> that time). >> >> Did Atmel 3204 report wrong but non-zero timeouts? > > Wouldn't it make more sense to fix this by re-adding this fallback? I think it would be a cleaner fix and also catch other problematic devices (if there are any) without needing to add individual overrides. > /Jarkko Maciej
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] tpm_tis: override reported C and D timeouts for Atmel 3203 "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2017-01-12 19:20 +0100
Re: [PATCH] tpm_tis: override reported C and D timeouts for Atmel 3203 Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-01-12 19:50 +0100
Re: [PATCH] tpm_tis: override reported C and D timeouts for Atmel 3203 "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2017-01-12 21:10 +0100
Re: [PATCH] tpm_tis: override reported C and D timeouts for Atmel 3203 Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-01-12 21:20 +0100
Re: [PATCH] tpm_tis: override reported C and D timeouts for Atmel 3203 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-12 21:30 +0100
Re: [PATCH] tpm_tis: override reported C and D timeouts for Atmel 3203 "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2017-01-12 22:40 +0100
Re: [PATCH] tpm_tis: override reported C and D timeouts for Atmel 3203 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-13 17:00 +0100
csiph-web