[PATCH v2 4/4] staging: android/ion: Use variable names in header

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Bogdan Purcareata <bogdan.purcareata@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 4/4] staging: android/ion: Use variable names in header
Date	Thu, 12 Jan 2017 23:10:01 +0100
Message-ID	<sYVJf-Zh-9@gated-at.bofh.it> (permalink)
References	<sYVJf-Zh-7@gated-at.bofh.it>
X-Original-To	labbott@redhat.com, sumit.semwal@linaro.org, gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mHTUedYVgbVI3EuIXV0J7I0qJyAARUBKkff5/3WHYdE=; b=YGoRDjIuFX1M2RXbOMBcKqGV2d8MSV2TJ9sS7Zxl72cW2DqvpghqPIePp60Ka/BI4g +JLbV4JBfklyrAvF1sK9Etnh3BN4Kw9DArFHDkVWmHf3zoGtRuMzANjwC3FrJi2hJiW0 cRAMfIeS56jdaYOSV0tfqicpSGkkVe+ZcQ0FnN+SmW1a/0SH9uLvyPHpIrRx3tcmtTK9 XypWkv9+l+5UpNt3L7Lj3PGMGNd6SwafrFfnsuu6uqdPKpfSYCc4jBxrDOgNA1yFiHVj /riFT5vpZc+5Chr/MXjt+CcWXNF3CW9hNFdt30iLF3P5KWZYvpotRTljaTGXnr32jdaO bXDw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mHTUedYVgbVI3EuIXV0J7I0qJyAARUBKkff5/3WHYdE=; b=cxGx2CWOaZDJ3WOczis48RiG62cAc2qEDmSMGLYidg/m71R+CbrBzZN9A8v8yiuZXy Q/o0+Q/sZBDLN1faKEdwHNnOPYGquvHQiUC4ABQquuN/SoB4hdz8maaRr7ptZXJ9vxM3 Lq5TXqKYUrNCnIZVjGlRzAMpdKXpwcvN4Tf5AYc3xhE/QCpniQZfGNMsUFbF9+TopMT2 a3PvYGuuWU0b+5yd29yPlBZjnsiVbpp7nJwpLTxF8PsIfzSNjh0GEmfvO8BfGa0cYHzJ C7QJYyt1EB13Z7sPPJHvl4egaFsvdaH08QHslK3dN6JNXHIDYNPwedyHPWt0LxKXFAcE dUtg==
X-Gm-Message-State	AIkVDXKqkcpDvdcXUHRQB2g2hD4nXZU9+6kKhogarbzDZ76NFoZAGplgspslxpau9KaFzQ==
X-Received	by 10.28.71.133 with SMTP id m5mr168526wmi.132.1484258531054; Thu, 12 Jan 2017 14:02:11 -0800 (PST)
X-Mailer	git-send-email 2.7.4
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	79
Organization	linux.* mail to news gateway
X-Original-Cc	Bogdan Purcareata <bogdan.purcareata@gmail.com>
X-Original-Date	Fri, 13 Jan 2017 00:01:56 +0200
X-Original-Message-ID	<1484258516-2792-4-git-send-email-bogdan.purcareata@gmail.com>
X-Original-References	<1484258516-2792-1-git-send-email-bogdan.purcareata@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1557852

Show key headers only | View raw

Populate header function signatures with variable names as well, not
just variable types.

Signed-off-by: Bogdan Purcareata <bogdan.purcareata@gmail.com>
---
v1 -> v2:
- fix CHECK report from checkpatch

 drivers/staging/android/ion/ion_priv.h | 38 +++++++++++++++++-----------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/drivers/staging/android/ion/ion_priv.h b/drivers/staging/android/ion/ion_priv.h
index 00d8b53..5b3059c 100644
--- a/drivers/staging/android/ion/ion_priv.h
+++ b/drivers/staging/android/ion/ion_priv.h
@@ -287,10 +287,10 @@ void ion_device_add_heap(struct ion_device *dev, struct ion_heap *heap);
  * some helpers for common operations on buffers using the sg_table
  * and vaddr fields
  */
-void *ion_heap_map_kernel(struct ion_heap *, struct ion_buffer *);
-void ion_heap_unmap_kernel(struct ion_heap *, struct ion_buffer *);
-int ion_heap_map_user(struct ion_heap *, struct ion_buffer *,
-			struct vm_area_struct *);
+void *ion_heap_map_kernel(struct ion_heap *heap, struct ion_buffer *buffer);
+void ion_heap_unmap_kernel(struct ion_heap *heap, struct ion_buffer *buffer);
+int ion_heap_map_user(struct ion_heap *heap, struct ion_buffer *buffer,
+		      struct vm_area_struct *vma);
 int ion_heap_buffer_zero(struct ion_buffer *buffer);
 int ion_heap_pages_zero(struct page *page, size_t size, pgprot_t pgprot);
 
@@ -371,21 +371,21 @@ size_t ion_heap_freelist_size(struct ion_heap *heap);
  * heaps as appropriate.
  */
 
-struct ion_heap *ion_heap_create(struct ion_platform_heap *);
-void ion_heap_destroy(struct ion_heap *);
-struct ion_heap *ion_system_heap_create(struct ion_platform_heap *);
-void ion_system_heap_destroy(struct ion_heap *);
+struct ion_heap *ion_heap_create(struct ion_platform_heap *heap_data);
+void ion_heap_destroy(struct ion_heap *heap);
+struct ion_heap *ion_system_heap_create(struct ion_platform_heap *unused);
+void ion_system_heap_destroy(struct ion_heap *heap);
 
-struct ion_heap *ion_system_contig_heap_create(struct ion_platform_heap *);
-void ion_system_contig_heap_destroy(struct ion_heap *);
+struct ion_heap *ion_system_contig_heap_create(struct ion_platform_heap *heap);
+void ion_system_contig_heap_destroy(struct ion_heap *heap);
 
-struct ion_heap *ion_carveout_heap_create(struct ion_platform_heap *);
-void ion_carveout_heap_destroy(struct ion_heap *);
+struct ion_heap *ion_carveout_heap_create(struct ion_platform_heap *heap_data);
+void ion_carveout_heap_destroy(struct ion_heap *heap);
 
-struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *);
-void ion_chunk_heap_destroy(struct ion_heap *);
-struct ion_heap *ion_cma_heap_create(struct ion_platform_heap *);
-void ion_cma_heap_destroy(struct ion_heap *);
+struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data);
+void ion_chunk_heap_destroy(struct ion_heap *heap);
+struct ion_heap *ion_cma_heap_create(struct ion_platform_heap *data);
+void ion_cma_heap_destroy(struct ion_heap *heap);
 
 /**
  * functions for creating and destroying a heap pool -- allows you
@@ -427,9 +427,9 @@ struct ion_page_pool {
 
 struct ion_page_pool *ion_page_pool_create(gfp_t gfp_mask, unsigned int order,
 					   bool cached);
-void ion_page_pool_destroy(struct ion_page_pool *);
-struct page *ion_page_pool_alloc(struct ion_page_pool *);
-void ion_page_pool_free(struct ion_page_pool *, struct page *);
+void ion_page_pool_destroy(struct ion_page_pool *pool);
+struct page *ion_page_pool_alloc(struct ion_page_pool *pool);
+void ion_page_pool_free(struct ion_page_pool *pool, struct page *page);
 
 /** ion_page_pool_shrink - shrinks the size of the memory cached in the pool
  * @pool:		the pool
-- 
2.7.4

Thread

[PATCH v2 1/4] staging: android/ion: Split function call Bogdan Purcareata <bogdan.purcareata@gmail.com> - 2017-01-12 23:10 +0100
  [PATCH v2 4/4] staging: android/ion: Use variable names in header Bogdan Purcareata <bogdan.purcareata@gmail.com> - 2017-01-12 23:10 +0100
  [PATCH v2 2/4] staging: android/ion: Don't use return in void function Bogdan Purcareata <bogdan.purcareata@gmail.com> - 2017-01-12 23:10 +0100
  [PATCH v2 3/4] staging: android/ion: Align comment mark Bogdan Purcareata <bogdan.purcareata@gmail.com> - 2017-01-12 23:10 +0100

csiph-web