Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1557809

[PATCH] perf/tool: remove unneccessary feature-dwarf warning

Show all headers | View raw

Don't warn for feature-dwarf==0 if user explicitily
disabled dwarf by NO_DWARF=1.

Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
---
 tools/perf/Makefile.config | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index 94318c07d89d..bf79344cd10c 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -291,8 +291,10 @@ else
       endif
     endif
     ifneq ($(feature-dwarf), 1)
-      msg := $(warning No libdw.h found or old libdw.h found or elfutils is older than 0.138, disables dwarf support. Please install new elfutils-devel/libdw-dev);
-      NO_DWARF := 1
+      ifndef NO_DWARF
+        msg := $(warning No libdw.h found or old libdw.h found or elfutils is older than 0.138, disables dwarf support. Please install new elfutils-devel/libdw-dev);
+        NO_DWARF := 1
+      endif
     else
       ifneq ($(feature-dwarf_getlocations), 1)
         msg := $(warning Old libdw.h, finding variables at given 'perf probe' point will not work, install elfutils-devel/libdw-dev >= 0.157);
-- 
2.11.0.390.gc69c2f50cf-goog

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf/tool: remove unneccessary feature-dwarf warning David Carrillo-Cisneros <davidcc@google.com> - 2017-01-12 22:10 +0100
  Re: [PATCH] perf/tool: remove unneccessary feature-dwarf warning Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-13 15:50 +0100

csiph-web