[PATCH -next] drm/hisilicon/hibmc: Fix wrong pointer passed to PTR_ERR()

From	Wei Yongjun <weiyj.lk@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH -next] drm/hisilicon/hibmc: Fix wrong pointer passed to PTR_ERR()
Date	2017-01-12 16:30 +0100
Message-ID	<sYPu9-5B2-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Wei Yongjun <weiyongjun1@huawei.com>

PTR_ERR should access the value just tested by IS_ERR, otherwise
the wrong error code will be returned.

Fixes: d1667b86795a ("drm/hisilicon/hibmc: Add support for frame buffer")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c
index 7a6957a..16fe790 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c
@@ -121,7 +121,7 @@ static int hibmc_drm_fb_create(struct drm_fb_helper *helper,
 
 	hi_fbdev->fb = hibmc_framebuffer_init(priv->dev, &mode_cmd, gobj);
 	if (IS_ERR(hi_fbdev->fb)) {
-		ret = PTR_ERR(info);
+		ret = PTR_ERR(hi_fbdev->fb);
 		DRM_ERROR("failed to initialize framebuffer: %d\n", ret);
 		goto out_release_fbi;
 	}

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH -next] drm/hisilicon/hibmc: Fix wrong pointer passed to PTR_ERR() Wei Yongjun <weiyj.lk@gmail.com> - 2017-01-12 16:30 +0100

csiph-web