[PATCH] usb: dwc2: host: fix Wmaybe-uninitialized warning

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Nicholas Mc Guire <hofrat@osadl.org>
Newsgroups	linux.kernel
Subject	[PATCH] usb: dwc2: host: fix Wmaybe-uninitialized warning
Date	Thu, 12 Jan 2017 17:00:01 +0100
Message-ID	<sYPXb-5KY-7@gated-at.bofh.it> (permalink)
X-Mailer	git-send-email 2.1.4
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	35
Organization	linux.* mail to news gateway
X-Original-Cc	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire <hofrat@osadl.org>
X-Original-Date	Thu, 12 Jan 2017 16:54:38 +0100
X-Original-Message-ID	<1484236478-308-1-git-send-email-hofrat@osadl.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1557549

Show key headers only | View raw

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
Problem reported by sparse
drivers/usb/dwc2/hcd.c: In function 'dwc2_dump_urb_info':
./include/linux/dynamic_debug.h:134:3: warning: 'pipetype' may be used uninitialized in this function [-Wmaybe-uninitialized]
   __dynamic_dev_dbg(&descriptor, dev, fmt, \
   ^
drivers/usb/dwc2/hcd.c:4492:8: note: 'pipetype' was declared here
  char *pipetype;
        ^
Patch was compile tested with: x86_64_defconfig + CONFIG_USB_DWC2=m +
CONFIG_USB_DWC2_VERBOSE=y

Patch is against 4.10-rc3 (localversion-next is next-20170112)

 drivers/usb/dwc2/hcd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 911c3b3..9f66777 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -4489,8 +4489,8 @@ static void dwc2_dump_urb_info(struct usb_hcd *hcd, struct urb *urb,
 {
 #ifdef VERBOSE_DEBUG
 	struct dwc2_hsotg *hsotg = dwc2_hcd_to_hsotg(hcd);
-	char *pipetype;
-	char *speed;
+	char *pipetype = NULL;
+	char *speed = NULL;
 
 	dev_vdbg(hsotg->dev, "%s, urb %p\n", fn_name, urb);
 	dev_vdbg(hsotg->dev, "  Device address: %d\n",
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: dwc2: host: fix Wmaybe-uninitialized warning Nicholas Mc Guire <hofrat@osadl.org> - 2017-01-12 17:00 +0100
  Re: [PATCH] usb: dwc2: host: fix Wmaybe-uninitialized warning Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-12 17:30 +0100
    Re: [PATCH] usb: dwc2: host: fix Wmaybe-uninitialized warning Nicholas Mc Guire <der.herr@hofr.at> - 2017-01-12 17:40 +0100

csiph-web