Re: [PATCH] ASoC: rt5651: use msleep for large delays

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: rt5651: use msleep for large delays
Date	2017-01-12 16:40 +0100
Message-ID	<sYPDR-5Es-35@gated-at.bofh.it> (permalink)
References	<sYpJn-6v8-9@gated-at.bofh.it> <sYsHg-8rV-69@gated-at.bofh.it> <sYsQW-8vl-33@gated-at.bofh.it> <sYvvt-1Kq-41@gated-at.bofh.it> <sYwrv-2jK-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Jan 11, 2017 at 06:59:52PM +0000, Nicholas Mc Guire wrote:
> On Wed, Jan 11, 2017 at 06:06:58PM +0000, Mark Brown wrote:

> > Yes, but as fairly recently discussed somewhere on the lists (and IIRC
> > actually fixed) approximately no users expect or want that behaviour -

> True its an odd behavior - the point just was to change the actual behavior
> as little from current state as one might expect. Anywa - will fix it up 

Unfortunately the current state will often reflect a change from the
original or at least expected behaviour.

> then and resend - in this particular case it really makes little 

Thanks.

> difference - assuming that both the minimum and maximum value were 
> suitable to ensure that the writes had compled or it was actually a failure.

It can create confusion where the delay comes from a datasheet or tech
note and people are left wondering why a different value is used by the
kernel, and in a lot of the paths with delays in them are pretty
sensitive to the overall time to run so there's a strong desire to keep
the delays as low as possible.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: rt5651: use msleep for large delays Nicholas Mc Guire <hofrat@osadl.org> - 2017-01-11 13:00 +0100
  Re: [PATCH] ASoC: rt5651: use msleep for large delays Mark Brown <broonie@kernel.org> - 2017-01-11 16:10 +0100
    Re: [PATCH] ASoC: rt5651: use msleep for large delays Nicholas Mc Guire <der.herr@hofr.at> - 2017-01-11 16:20 +0100
      Re: [PATCH] ASoC: rt5651: use msleep for large delays Mark Brown <broonie@kernel.org> - 2017-01-11 19:10 +0100
        Re: [PATCH] ASoC: rt5651: use msleep for large delays Nicholas Mc Guire <der.herr@hofr.at> - 2017-01-11 20:10 +0100
          Re: [PATCH] ASoC: rt5651: use msleep for large delays Mark Brown <broonie@kernel.org> - 2017-01-12 16:40 +0100

csiph-web