Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1557512
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next 1/4] siphash: add cryptographically secure PRF |
| Date | 2017-01-12 16:40 +0100 |
| Message-ID | <sYPDQ-5Es-17@gated-at.bofh.it> (permalink) |
| References | <sWQul-3Dm-9@gated-at.bofh.it> |
| Organization | Core |
Eric Biggers <ebiggers3@gmail.com> wrote:
> Hi Jason, just a few comments:
>
> On Fri, Jan 06, 2017 at 09:10:52PM +0100, Jason A. Donenfeld wrote:
>> +#define SIPHASH_ALIGNMENT __alignof__(u64)
>> +typedef u64 siphash_key_t[2];
>
> I was confused by all the functions passing siphash_key_t "by value" until I saw
> that it's actually typedefed to u64[2]. Have you considered making it a struct
> instead, something like this?
>
> typedef struct {
> u64 v[2];
> } siphash_key_t;
If it's just an 128-bit value then we have u128 in crypto/b128ops.h
that could be generalised for this.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next 1/4] siphash: add cryptographically secure PRF "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-01-06 19:40 +0100
[PATCH net-next 2/4] siphash: implement HalfSipHash1-3 for hash tables "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-01-06 19:40 +0100
[PATCH net-next 3/4] secure_seq: use SipHash in place of MD5 "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-01-06 19:40 +0100
Re: [PATCH net-next 1/4] siphash: add cryptographically secure PRF David Miller <davem@davemloft.net> - 2017-01-06 21:00 +0100
Re: [PATCH net-next 1/4] siphash: add cryptographically secure PRF "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-01-06 21:10 +0100
[PATCH net-next 2/4] siphash: implement HalfSipHash1-3 for hash tables "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-01-06 21:20 +0100
Re: [PATCH net-next 2/4] siphash: implement HalfSipHash1-3 for hash tables Jean-Philippe Aumasson <jeanphilippe.aumasson@gmail.com> - 2017-01-06 21:40 +0100
[PATCH net-next 3/4] secure_seq: use SipHash in place of MD5 "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-01-06 21:20 +0100
[PATCH net-next 0/4] Introduce The SipHash PRF "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-01-06 21:20 +0100
[PATCH net-next 1/4] siphash: add cryptographically secure PRF "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-01-06 21:20 +0100
Re: [PATCH net-next 1/4] siphash: add cryptographically secure PRF Jean-Philippe Aumasson <jeanphilippe.aumasson@gmail.com> - 2017-01-06 21:40 +0100
Re: [PATCH net-next 1/4] siphash: add cryptographically secure PRF David Miller <davem@davemloft.net> - 2017-01-06 21:50 +0100
Re: [PATCH net-next 1/4] siphash: add cryptographically secure PRF Eric Biggers <ebiggers3@gmail.com> - 2017-01-07 05:10 +0100
Re: [PATCH net-next 1/4] siphash: add cryptographically secure PRF "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-01-07 14:20 +0100
Re: [PATCH net-next 1/4] siphash: add cryptographically secure PRF Herbert Xu <herbert@gondor.apana.org.au> - 2017-01-12 16:40 +0100
Re: [PATCH net-next 1/4] siphash: add cryptographically secure PRF "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-01-12 19:40 +0100
[PATCH net-next 4/4] syncookies: use SipHash in place of SHA1 "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-01-06 21:20 +0100
csiph-web