Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1557445

Re: [PATCH 1/2] dma-mapping: let arch know origin of dma range passed to arch_setup_dma_ops()

Show all headers | View raw

On Thursday, January 12, 2017 12:16:24 PM CET Will Deacon wrote:
> On Thu, Jan 12, 2017 at 08:52:51AM +0300, Nikita Yushchenko wrote:
> > >> diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
> > >> index 5ac373c..480b644 100644
> > >> --- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
> > >> +++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
> > >> @@ -540,7 +540,7 @@ int fsl_mc_device_add(struct dprc_obj_desc *obj_desc,
> > >>  
> > >>    /* Objects are coherent, unless 'no shareability' flag set. */
> > >>    if (!(obj_desc->flags & DPRC_OBJ_FLAG_NO_MEM_SHAREABILITY))
> > >> -          arch_setup_dma_ops(&mc_dev->dev, 0, 0, NULL, true);
> > >> +          arch_setup_dma_ops(&mc_dev->dev, 0, 0, false, NULL, true);
> > >>  
> > >>    /*
> > >>     * The device-specific probe callback will get invoked by device_add()
> > > 
> > > Why are these actually calling arch_setup_dma_ops() here in the first
> > > place? Are these all devices that are DMA masters without an OF node?
> > 
> > I don't know, but that's a different topic. This patch just adds
> > argument and sets it to false everywhere but in the location when range
> > should be definitely enforced.
> 
> I also wouldn't lose any sleep over a staging driver.

I think this is in the process of being moved out of staging, and
my question was about the other two as well:

drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
drivers/iommu/rockchip-iommu.c

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] arm64: fix handling of DMA masks wider than bus supports Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-01-11 19:40 +0100
  [PATCH 1/2] dma-mapping: let arch know origin of dma range passed to arch_setup_dma_ops() Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-01-11 19:40 +0100
    Re: [PATCH 1/2] dma-mapping: let arch know origin of dma range passed to arch_setup_dma_ops() Arnd Bergmann <arnd@arndb.de> - 2017-01-11 22:20 +0100
      Re: [PATCH 1/2] dma-mapping: let arch know origin of dma range passed  to arch_setup_dma_ops() Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-01-12 07:10 +0100
        Re: [PATCH 1/2] dma-mapping: let arch know origin of dma range passed  to arch_setup_dma_ops() Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-01-12 07:40 +0100
          Re: [PATCH 1/2] dma-mapping: let arch know origin of dma range passed to arch_setup_dma_ops() Arnd Bergmann <arnd@arndb.de> - 2017-01-12 14:30 +0100
            Re: [PATCH 1/2] dma-mapping: let arch know origin of dma range passed  to arch_setup_dma_ops() Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-01-12 14:50 +0100
        Re: [PATCH 1/2] dma-mapping: let arch know origin of dma range  passed to arch_setup_dma_ops() Will Deacon <will.deacon@arm.com> - 2017-01-12 13:20 +0100
          Re: [PATCH 1/2] dma-mapping: let arch know origin of dma range passed to arch_setup_dma_ops() Arnd Bergmann <arnd@arndb.de> - 2017-01-12 14:30 +0100
            Re: [PATCH 1/2] dma-mapping: let arch know origin of dma range passed  to arch_setup_dma_ops() Robin Murphy <robin.murphy@arm.com> - 2017-01-12 14:50 +0100
    Re: [PATCH 1/2] dma-mapping: let arch know origin of dma range  passed to arch_setup_dma_ops() kbuild test robot <lkp@intel.com> - 2017-01-13 11:50 +0100

csiph-web