Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1557382

Re: [PATCH] rtc: armada38x: hide maybe-uninitialized warning

Show all headers | View raw

Hi Arnd,

On 11/01/2017 at 15:50:31 +0100, Arnd Bergmann wrote :
> The function is too complicated for gcc to realize that this variable
> does eventually get initialized, causing a harmless warning:
> 
> drivers/rtc/rtc-armada38x.c: In function 'read_rtc_register_wa':
> drivers/rtc/rtc-armada38x.c:131:25: warning: 'index_max' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> This adds an explicit initializion at the start of the function.
> I generally try to avoid that, but it seems appropriate here,
> as we start out with max=0 as well.
> 
> Fixes: 61cffa2438e3 ("rtc: armada38x: Follow the new recommendation for errata implementation")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Actually, I fixed that one directly in the commit yesterday as it has
been reported to me multiple times already.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: armada38x: hide maybe-uninitialized warning Arnd Bergmann <arnd@arndb.de> - 2017-01-11 16:00 +0100
  Re: [PATCH] rtc: armada38x: hide maybe-uninitialized warning Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-01-12 12:30 +0100

csiph-web