Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1557229

Re: [PATCHv3 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC

From Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Newsgroups linux.kernel
Subject Re: [PATCHv3 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC
Date 2017-01-12 10:30 +0100
Message-ID <sYJRL-2er-5@gated-at.bofh.it> (permalink)
References <sW74d-5AZ-3@gated-at.bofh.it> <sWuat-4AF-3@gated-at.bofh.it> <sWuat-4AF-1@gated-at.bofh.it> <sYsnT-86a-5@gated-at.bofh.it> <sYy9Y-3aX-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 12/01/17 09:56, Sebastian Hesselbarth wrote:
> On 01/11/2017 03:44 PM, Linus Walleij wrote:
>> On Fri, Jan 6, 2017 at 5:15 AM, Chris Packham
>> <chris.packham@alliedtelesis.co.nz> wrote:
>>
>>> From: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>
>>>
>>> This pinctrl driver supports the 98DX3236, 98DX3336 and 98DX4251 SoCs
>>> from Marvell.
>>>
>>> Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>
>>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>>
>> I am waiting for an ACK or comment from the maintainers on
>> this patch. Sebastian?
>
> Sorry for the ignorance.
>
> I don't have the patch to reply to inline, but:
>
> - In the driver MPP_MODE2, spi0 there is a typo "csk" instead of "sck".
> - MPP_MODE5 binding "dev","bootcs" and driver "dev","bootcs0" differ.
> - MPP_MODE6 binding "gpio" and driver "gpo" differ.
> - MPP_MODE17 binding "dev","clk" and driver "dev","clkout" differ.
> - MPP_MODE19 binding mentiones "dev","rb" but driver does not.
> - MPP_MODE20 binding "gpio" and driver "gpo" differ.
> - MPP_MODE20 binding "dev","we" and driver "dev","we0" differ.
> - MPP_MODE21 through MPP_MODE30 binding "gpio" and driver "gpo" differ.
> - remove spaces before "0,     0" in mv98dx3236_mpp_gpio_ranges.
>
> Most of it is cosmetic stuff, so if you fix it feel free to add my
>
> Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>

Hi Sebastian,

Hopefully I can get a v4 out with the above fixed soon.

One point on "gpio" vs "gpo" this one isn't a typo. Some of these pins 
can be driven as outputs but can't be used as inputs. From a pinctrl 
driver point of view there is no difference but I did want to convey 
that from a system design point of view if you really need something to 
be an input you shouldn't use one of these pins. This is also noted in 
the datasheets so it doesn't necessarily need repeating. If you still 
want me to use "gpio" in the code and binding I'm happy to do so.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv2 0/5] Support for Marvell switches with integrated CPUs Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-01-05 04:40 +0100
  [PATCHv2 5/5] arm: mvebu: Add device tree for db-dxbc2 and db-xc3-24g4xg boards Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-01-05 04:40 +0100
  [PATCHv2 2/5] arm: mvebu: support for SMP on 98DX3336 SoC Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-01-05 04:40 +0100
    Re: [PATCHv2 2/5] arm: mvebu: support for SMP on 98DX3336 SoC Florian Fainelli <f.fainelli@gmail.com> - 2017-01-05 05:10 +0100
      Re: [PATCHv2 2/5] arm: mvebu: support for SMP on 98DX3336 SoC Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-01-05 05:50 +0100
        Re: [PATCHv2 2/5] arm: mvebu: support for SMP on 98DX3336 SoC Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-01-05 22:00 +0100
  [PATCHv2 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-01-05 04:40 +0100
    Re: [PATCHv2 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs Florian Fainelli <f.fainelli@gmail.com> - 2017-01-05 05:10 +0100
      Re: [PATCHv2 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-01-05 05:40 +0100
    Re: [PATCHv2 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs Mark Rutland <mark.rutland@arm.com> - 2017-01-05 15:00 +0100
      Re: [PATCHv2 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-01-05 21:20 +0100
  [PATCHv2 1/5] clk: mvebu: support for 98DX3236 SoC Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-01-05 04:40 +0100
    Re: [PATCHv2 1/5] clk: mvebu: support for 98DX3236 SoC Mark Rutland <mark.rutland@arm.com> - 2017-01-05 15:00 +0100
      Re: [PATCHv2 1/5] clk: mvebu: support for 98DX3236 SoC Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-01-06 00:10 +0100
  Re: [PATCHv2 0/5] Support for Marvell switches with integrated CPUs Florian Fainelli <f.fainelli@gmail.com> - 2017-01-05 05:10 +0100
    Re: [PATCHv2 0/5] Support for Marvell switches with integrated CPUs Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-01-05 05:30 +0100
      Re: [PATCHv2 0/5] Support for Marvell switches with integrated CPUs Andrew Lunn <andrew@lunn.ch> - 2017-01-05 14:20 +0100
        Re: [PATCHv2 0/5] Support for Marvell switches with integrated CPUs Marcin Wojtas <mw@semihalf.com> - 2017-01-05 15:10 +0100
        Re: [PATCHv2 0/5] Support for Marvell switches with integrated CPUs Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-01-05 20:50 +0100
          Re: [PATCHv2 0/5] Support for Marvell switches with integrated CPUs Florian Fainelli <f.fainelli@gmail.com> - 2017-01-05 21:00 +0100
  Re: [PATCHv2 0/5] Support for Marvell switches with integrated CPUs Marcin Wojtas <mw@semihalf.com> - 2017-01-05 15:10 +0100
    Re: [PATCHv2 0/5] Support for Marvell switches with integrated CPUs Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-01-05 21:10 +0100
  [PATCHv3 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-01-06 05:20 +0100
    Re: [PATCHv3 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC Rob Herring <robh@kernel.org> - 2017-01-09 19:50 +0100
    Re: [PATCHv3 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC Linus Walleij <linus.walleij@linaro.org> - 2017-01-11 15:50 +0100
      Re: [PATCHv3 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2017-01-11 22:00 +0100
        Re: [PATCHv3 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-01-12 10:30 +0100
  [PATCHv3 1/5] clk: mvebu: support for 98DX3236 SoC Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-01-06 05:20 +0100
    Re: [PATCHv3 1/5] clk: mvebu: support for 98DX3236 SoC Rob Herring <robh@kernel.org> - 2017-01-09 19:40 +0100
  [PATCHv2 0/5] Support for Marvell switches with integrated CPUs Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-01-06 05:20 +0100
    [PATCHv3 5/5] arm: mvebu: Add device tree for db-dxbc2 and db-xc3-24g4xg boards Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-01-06 05:20 +0100
    [PATCHv3 2/5] arm: mvebu: support for SMP on 98DX3336 SoC Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-01-06 05:20 +0100
      Re: [PATCHv3 2/5] arm: mvebu: support for SMP on 98DX3336 SoC Stephen Boyd <sboyd@codeaurora.org> - 2017-01-06 07:40 +0100
        Re: [PATCHv3 2/5] arm: mvebu: support for SMP on 98DX3336 SoC Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-01-06 14:10 +0100
      Re: [PATCHv3 2/5] arm: mvebu: support for SMP on 98DX3336 SoC Rob Herring <robh@kernel.org> - 2017-01-09 19:50 +0100
    [PATCHv3 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-01-06 05:30 +0100
      Re: [PATCHv3 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs Rob Herring <robh@kernel.org> - 2017-01-09 19:50 +0100

csiph-web